Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions workflow #3718

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

w00000dy
Copy link
Contributor

This updates the GitHub Actions workflow and all the GitHub Actions used.

This was necessary because the old workflow was throwing warnings:
grafik

I also optimized the caching for PlatformIO. Now building is much faster:

Before Now
grafik grafik
grafik grafik

I also removed some unnecessary code, like caching the python setup with the actions/cache action. Here we can just use the built-in cache function of the actions/setup-python action.
The GITHUB_TOKEN is also not needed. You would only need a GITHUB_TOKEN if you want to create releases in other repositories.

In the previous version, we had build_output/firmware/*.bin.gz and build_output/firmware/*.bin files in the artifacts. I see no reason to do this. It just combines the disadvantages of uncompressed files and the disadvantages of compressed files.

When creating a new tag, I also see no reason to have the files from build_output/firmware and build_output/release. They are the same files, just with different filenames. So now I have changed it so that we always use the release files for artifacts.

Creating a draft release with built files whenever a new tag is created remains the same.

This also adds a WLED_RELEASE_NAME for esp32s3dev_8MB_PSRAM_opi
@dosipod
Copy link
Contributor

dosipod commented Jan 24, 2024

@WoodyLetsCode As usual excellent work , i was wondering why keep the gz as it is only useful for esp02 and the size does add up
image

@w00000dy
Copy link
Contributor Author

@dosipod Thanks for the hint on ESP02! I didn't know we needed bin.gz files for ESP02.
I also found out that @softhack007 asked for this here: #3390 (comment)

So I will change this and add bin.gz files for ESP02 to the artifacts as well.
Are bin.gz files only needed for ESP02 or also for ESP01 or ESP8266?

@dosipod
Copy link
Contributor

dosipod commented Jan 24, 2024

@WoodyLetsCode No gz is only needed for esp02 ( 2MB ) when using OTA , ESP01 1MB does not work with OTA so gz is useless . The normal esp8266 4MB OTA will work without gz

@w00000dy
Copy link
Contributor Author

So now for ESP02 we have two files in the artifact:

  • WLED_0.15.0-a0_ESP02.bin
  • WLED_0.15.0-a0_ESP02.bin.gz

@blazoncek blazoncek merged commit 590d454 into Aircoookie:0_15 Feb 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants