Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ST7789_display usermod into a more generic TFT_display usermod #4072

Open
wants to merge 1 commit into
base: 0_15
Choose a base branch
from

Conversation

axlan
Copy link
Contributor

@axlan axlan commented Jul 24, 2024

Changes

  • Renamed usermod to TFT_display
  • Bug fixes (problems checking if redraw needed, mistake in appendConfigData pin indexing, etc.)
  • Made indentation consistent 2 spaces
  • Added warning for RO config options
  • Moved USERMOD_ID_TFT_DISPLAY to const.h
  • Made rotation and font size configuration options
  • Added additional build macros to make supporting other displays easier
  • Updated documentation for supporting generic displays
  • Added platformio_override.sample.ini for targeting T-QT Pro dev board

@blazoncek
Copy link
Collaborator

Please check ST7789_display usermod and possibly combine the two.

The container modification should be separate PR.

@axlan axlan changed the base branch from main to 0_15 July 25, 2024 20:24
@axlan axlan changed the title Added a usermod for TFT displays. Refactor the ST7789_display usermod into a more generic TFT_display usermod Jul 25, 2024
@axlan
Copy link
Contributor Author

axlan commented Jul 25, 2024

@blazoncek OK, I switched this PR to refactor the existing ST7789_display.

@softhack007
Copy link
Collaborator

softhack007 commented Jul 25, 2024

axlan force-pushed the tft-usermod branch from 427dac5 to e1dd03f 53 minutes ago

@axlan please don't force-push while you have a PR open. It leads to weird side effects in the main WLED github, like lost review comments, broken links, re-opened issue tickets etc.

@blazoncek
Copy link
Collaborator

Force pushing has become a bad habit with a lot of contributors lately. I will start closing such PRs regardless of their value as I really don't have the time to review such mess.

Please see how to properly submit a PR.

@softhack007 softhack007 added the usermod usermod related label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usermod usermod related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants