Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep selected FX while searching #4284

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

blazoncek
Copy link
Collaborator

Requested on Discord.
@w00000dy please review if you can.

Copy link
Contributor

@w00000dy w00000dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this in general, but I personally would like to see the selected option at the end of the search results instead of at the top. Because I think it is more important to see the search result at the top than the selected effect. If you agree with me, you can merge my PR blazoncek#46.

@willmmiles
Copy link
Collaborator

I agree with this in general, but I personally would like to see the selected option at the end of the search results instead of at the top. Because I think it is more important to see the search result at the top than the selected effect. If you agree with me, you can merge my PR blazoncek#46.

I concur with @w00000dy - keeping the selected FX at the bottom by the controls makes more sense to me.

@blazoncek
Copy link
Collaborator Author

Adding blazoncek#46 was beyond my skill and understanding. Thanks @w00000dy .

Move selected to the bottom in search result
@netmindz netmindz merged commit 0b54034 into Aircoookie:0_15 Nov 26, 2024
20 checks passed
@blazoncek blazoncek deleted the search-keep branch November 29, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants