palette effect overflow fix #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Note: this does replace some more 32 bit multiplications with slightly more expensive 64 bit multiplications. |
|
Tested and works. |
softhack007
reviewed
Dec 28, 2024
| @@ -2032,7 +2032,7 @@ uint16_t mode_palette() { | |||
| const mathType sourceX = xtSinTheta + ytCosTheta + centerX; | |||
| // The computation was scaled just right so that the result should always be in range [0, maxXOut], but enforce this anyway | |||
| // to account for imprecision. Then scale it so that the range is [0, 255], which we can use with the palette. | |||
| int colorIndex = (std::min(std::max(sourceX, mathType(0)), maxXOut * sInt16Scale) * 255) / (sInt16Scale * maxXOut); | |||
| int colorIndex = (std::min(std::max(sourceX, mathType(0)), maxXOut * sInt16Scale) * wideMathType(255)) / (sInt16Scale * maxXOut); | |||
There was a problem hiding this comment.
What does wideMathType() do?
Essentially this PR changes "255" to "wideMathType(255)", I'm wondering is this the same as writing "255.0f" or maybe "255L" ?
There was a problem hiding this comment.
255ULL for ESP8266 and 255.0f otherwise
There was a problem hiding this comment.
Looks like someone tried to avoid fixed point math?
There was a problem hiding this comment.
the way it is implemented is quite an elegant way to support float AND fixed point math.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I belive this fixes #4425