Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap to tasmota/platform-espressif32 #4487

Merged
merged 16 commits into from
Jan 15, 2025
Merged

Swap to tasmota/platform-espressif32 #4487

merged 16 commits into from
Jan 15, 2025
+52 −15

Conversation

netmindz
Copy link
Collaborator

@netmindz netmindz commented Jan 13, 2025 •
edited
Loading

Reduce the image size by swapping to tasmota's version of platform-espressif32

Motivation is that otherwise the move to IDF V4 means we run out of space

netmindz
netmindz commented Jan 13, 2025
View reviewed changes
platformio.ini Outdated Show resolved Hide resolved
netmindz
netmindz commented Jan 13, 2025
View reviewed changes
platformio.ini
Comment on lines -276 to +278
platform = espressif32@ ~6.3.2
platform_packages = platformio/framework-arduinoespressif32 @ 3.20009.0 ;; select arduino-esp32 v2.0.9 (arduino-esp32 2.0.10 thru 2.0.14 are buggy so avoid them)

;; select arduino-esp32 v2.0.9 (arduino-esp32 2.0.10 thru 2.0.14 are buggy so avoid them)
platform = https://github.com/tasmota/platform-espressif32/releases/download/2023.06.02/platform-espressif32.zip ;; Tasmota Arduino Core 2.0.9 with IPv6 support, based on IDF 4.4.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was aiming to keep the same version of the Arduino Core as before, just swapping to Tasmota.

Have I done this correctly? @Jason2866

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform (with removing the platform_packages entry) change is correct.

Copy link
Contributor

@Jason2866 Jason2866 Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I wouldn't remove platform_packages completely. Just the entry.
So all the other changes in the env are not needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the correct value of platform_packages be then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave it empy. As following
platform_packages =

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What impact would that have?

netmindz
netmindz commented Jan 13, 2025
View reviewed changes
platformio.ini Outdated Show resolved Hide resolved
@netmindz
Copy link
Collaborator Author

non V4

RAM:   [=         ]  14.8% (used 48504 bytes from 327680 bytes)
Flash: [========= ]  86.0% (used 1351933 bytes from 1572864 bytes)

V4 - default

RAM:   [==        ]  17.1% (used 55972 bytes from 327680 bytes)
Flash: [==========]  96.6% (used 1519301 bytes from 1572864 bytes)

V4 - Tasmota

RAM:   [=         ]  14.7% (used 48216 bytes from 327680 bytes)
Flash: [========  ]  78.4% (used 1233457 bytes from 1572864 bytes)

@netmindz netmindz marked this pull request as ready for review January 14, 2025 12:30
@netmindz netmindz added this to the 0.16.0 candidate milestone Jan 14, 2025
@DedeHai
Copy link
Collaborator

DedeHai commented Jan 14, 2025

esp32c3dev and esp32s3_4M_qspi are failing to compile

@netmindz
Copy link
Collaborator Author

esp32c3dev
fixed - set to qio

esp32s3_4M_qspi

Missing the board definition in Tasmota for some reason. Options are to either change the board or add a local copy of https://github.com/platformio/platform-espressif32/blob/master/boards/lolin_s3_mini.json to our repo. Thoughts?

@DedeHai
Copy link
Collaborator

DedeHai commented Jan 14, 2025

https://github.com/tasmota/platform-espressif32/blob/Arduino/IDF53/boards/adafruit_feather_esp32s3.json
has almost identical definitions but different "extra_flags" and an additional upload option "use_1200bps_touch": true,
I think it has little to no influence but I am not sure.

@Jason2866
Copy link
Contributor

The flag use_1200bps_touch has only an effect when TinyUsb is used in firmware.
For all boards not using TinyUsb strictly speaking this flag set is wrong.

@netmindz
Copy link
Collaborator Author

I have just added a local copy of the board to our repo for now. We can remove later when we move to a platform version that contains lolin_s3_mini

@netmindz
Copy link
Collaborator Author

All checks are now passing. Ok to approve? @blazoncek @softhack007

@blazoncek
Copy link
Collaborator

If you are confident, go ahead since I do not have proper time to test this on my end.
Will be able to look into it on weekend.

@netmindz netmindz merged commit 05098c3 into Aircoookie:V4 Jan 15, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason2866 Jason2866 Jason2866 left review comments

@blazoncek blazoncek Awaiting requested review from blazoncek

@softhack007 softhack007 Awaiting requested review from softhack007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0 candidate
Development

Successfully merging this pull request may close these issues.
5 participants
@netmindz @DedeHai @Jason2866 @blazoncek @softhack007