fix: fix wrong checks

Airfooox · Apr 15, 2020 · 2f6290e · 2f6290e
1 parent 76d59fa
commit 2f6290e
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/helper.ts b/src/helper.ts
@@ -19,9 +19,9 @@ const checkSingleElement = (
 ) => {
   if (element === '*') {
     if (!checkWildcardLimit(cronFieldType, options)) {
-      console.log(
-        `Field ${cronFieldType} uses wildcard '*', but is limited to ${options[cronFieldType].lowerLimit}-${options[cronFieldType].upperLimit}`
-      )
+      // console.log(
+      //   `Field ${cronFieldType} uses wildcard '*', but is limited to ${options[cronFieldType].lowerLimit}-${options[cronFieldType].upperLimit}`
+      // )
       return err(
         `Field ${cronFieldType} uses wildcard '*', but is limited to ${options[cronFieldType].lowerLimit}-${options[cronFieldType].upperLimit}`
       )
@@ -97,7 +97,7 @@ const checkFirstStepElement = (
   options: Options
 ) => {
   const rangeArray = firstStepElement.split('-')
-  if (rangeArray.length > 3) {
+  if (rangeArray.length > 2) {
     return err(
       `List element '${firstStepElement}' is not valid. (More than one '-')`
     )
@@ -125,7 +125,7 @@ const checkFirstStepElement = (
       return secondRangeElementResult
     }
 
-    if (rangeArray[0] > rangeArray[1]) {
+    if (Number(rangeArray[0]) > Number(rangeArray[1])) {
       return err(
         `Lower range end '${rangeArray[0]}' is bigger than upper range end '${rangeArray[1]}' of ${cronFieldType} field.`
       )
@@ -145,7 +145,8 @@ const checkListElement = (
   options: Options
 ) => {
   const stepArray = listElement.split('/')
-  if (stepArray.length > 3) {
+
+  if (stepArray.length > 2) {
     return err(
       `List element '${listElement}' is not valid. (More than one '/')`
     )