Remove assert module from source
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `assert` module from source and replaces it with
`if (...) { throw new Error(...) }`. This has a few benefits:
* Reduces the size of the browser build because we don't need to include
the `assert` module. Shaves off 12 KB from the minified build (from
72,458 bytes to 60,0280).
* When we switch ESLint, some of our code will error because we [don't
have consistent returns][1] in some of our functions. This fixes those
issues to ease the transition.
This is arguably a breaking change because we're now throwing regular
`Error`s instead of `assert.AssertionError`s, but I would argue that
this is safe.
[1]: https://eslint.org/docs/rules/consistent-return
kasrak
approved these changes
Apr 30, 2019
EvanHahn
pushed a commit
that referenced
this pull request
Jul 9, 2019
This switches us from JSHint to ESLint, improving the quality and consistency of our code. (We also use ESLint elsewhere at Airtable.) To break down this change: * We made several cleanups before this commit to ease the transition. See [#95][1], [#96][2], [#97][3], [#98][4], [#99][5], [#101][6] (and a fix in [#107][7]), [#105][8], [#109][9], [#118][10], [#119][11], [#120][12] * Installed `eslint` * Add `.eslintrc.json` and `.eslintignore` (and a slightly-different `.eslintrc.json` in `test`) * Remove JSHint. Involved uninstalling the package, removing it from the gruntfile, and removing `jshint ignore`s. * Update the `lint` task in `package.json` * Update `return` into `return void 0` for consistent returns in `callbackToPromise` * Add one `// eslint-disable-line` comment in a single test file * Run `eslint --fix .`, automatically fixing all of the remaining warnings and errors [1]: #95 [2]: #96 [3]: #97 [4]: #98 [5]: #99 [6]: #101 [7]: #107 [8]: #105 [9]: #109 [10]: #118 [11]: #119 [12]: #120
EvanHahn
pushed a commit
that referenced
this pull request
Jul 10, 2019
This switches us from JSHint to ESLint, improving the quality and consistency of our code. (We also use ESLint elsewhere at Airtable.) To break down this change: * We made several cleanups before this commit to ease the transition. See [#95][1], [#96][2], [#97][3], [#98][4], [#99][5], [#101][6] (and a fix in [#107][7]), [#105][8], [#109][9], [#118][10], [#119][11], [#120][12] * Install `eslint` * Add `.eslintrc.json` and `.eslintignore` (and a slightly-different `.eslintrc.json` in `test`) * Remove JSHint. Involved uninstalling the package, removing it from the gruntfile, and removing `jshint ignore`s. * Update the `lint` task in `package.json` * Update `return` into `return void 0` for consistent returns in `callbackToPromise` * Add one `// eslint-disable-line` comment in a single test file * Run `eslint --fix .`, automatically fixing all of the remaining warnings and errors [1]: #95 [2]: #96 [3]: #97 [4]: #98 [5]: #99 [6]: #101 [7]: #107 [8]: #105 [9]: #109 [10]: #118 [11]: #119 [12]: #120
PeterPan627
added a commit
to PeterPan627/airtable.js
that referenced
this pull request
May 28, 2023
This switches us from JSHint to ESLint, improving the quality and consistency of our code. (We also use ESLint elsewhere at Airtable.) To break down this change: * We made several cleanups before this commit to ease the transition. See [#95][1], [#96][2], [#97][3], [#98][4], [#99][5], [#101][6] (and a fix in [#107][7]), [#105][8], [#109][9], [#118][10], [#119][11], [#120][12] * Install `eslint` * Add `.eslintrc.json` and `.eslintignore` (and a slightly-different `.eslintrc.json` in `test`) * Remove JSHint. Involved uninstalling the package, removing it from the gruntfile, and removing `jshint ignore`s. * Update the `lint` task in `package.json` * Update `return` into `return void 0` for consistent returns in `callbackToPromise` * Add one `// eslint-disable-line` comment in a single test file * Run `eslint --fix .`, automatically fixing all of the remaining warnings and errors [1]: Airtable/airtable.js#95 [2]: Airtable/airtable.js#96 [3]: Airtable/airtable.js#97 [4]: Airtable/airtable.js#98 [5]: Airtable/airtable.js#99 [6]: Airtable/airtable.js#101 [7]: Airtable/airtable.js#107 [8]: Airtable/airtable.js#105 [9]: Airtable/airtable.js#109 [10]: Airtable/airtable.js#118 [11]: Airtable/airtable.js#119 [12]: Airtable/airtable.js#120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
assertmodule from source and replaces it withif (...) { throw new Error(...) }. This has a few benefits:assertmodule. Shaves off 12 KB from the minified build (from 72,458 bytes to 60,0280).assertmodule just fine, it removes a subtle difference between the browser build and Node.This is arguably a breaking change because we're now throwing regular
Errors instead ofassert.AssertionErrors, but I would argue that this is safe.