Improve documentation for testing #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlprat
reviewed
Apr 1, 2022
| the [testing docs](https://aiven.github.io/guardian-for-apache-kafka/testing/index.html) (typically when tests run | ||
| against actual services such as S3) | ||
|
|
||
| ### Docker |
There was a problem hiding this comment.
What about using podman as Docker is changing some of its licenses to privative ones?
There was a problem hiding this comment.
There appears to be some preliminary support for docker (see issue) but from what I can gather some trickery is required to get it to work with testcontainers-java (one of the main points of testcontainers is that it has as little friction as possible).
Lets make an issue on this to investigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This PR improves documentation and gotcha's for testing
Why this way
N/A