fix: align transitive compatibility checks #953
Merged
Commits on Oct 10, 2024
-
refactor: reorganize schema compatibility logic
This in preparation for the fix for [EC-289]. - Move schema compatibility related code from __init__.py to its own module (schema_compatibility.py) - Refactor logic in: - Schema registering endpoint (`/subjects/<subject-key>/versions`) - Schema compatibility endpoint (`/compatibility/subjects/<subject-key>/versions/latest`)
-
fix: align transitive compatibility checks
Make so that the transitive compatibility checks that are done in the schema creation endpoint are also done in the schema validation endpoint. In the creation endpoint (`/subjects/<subject-key>/versions`), if the compatibility mode is transient then the new schema is checked against all schemas. In the validation endpoint (`/compatibility/subjects/<subject-key>/versions/<schema-version>`): - Before this fix, only the latest schema is checked against (even in case of transitive mode) - After this fix, in case of transitive mode then all schema are checked against. Note that in this case the version provided in the POST request (`<schema-version>`) is ignored.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.