tests,backup: fix flakiness by using current timestamps #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
davide-armand
force-pushed
the
davide-armand/fix-flaky-test_roundtrip_from_kafka_state
branch
2 times, most recently
from
70484ef
to
09a4d06
Compare
davide-armand
changed the title
davide-armand
force-pushed
the
davide-armand/fix-flaky-test_roundtrip_from_kafka_state
branch
from
09a4d06
to
bfc96a2
Compare
Using some (old) fixed timestamps when producing messages was causing the messages to be automatically deleted because past message retention. I think most of the time the test was managing to complete successfully before the retention kicked in, making it fail only sometimes.
davide-armand
force-pushed
the
davide-armand/fix-flaky-test_roundtrip_from_kafka_state
branch
from
bfc96a2
to
cfc4e1a
Compare
|
Nice finding, I guess alternative fix could be to disable retention? (Asking because we most likely have the exact same issue in an internal project) |
eliax1996
approved these changes
Oct 25, 2024
eliax1996
deleted the
davide-armand/fix-flaky-test_roundtrip_from_kafka_state
branch
@aiven-anton Ah yes I guess that would work too, did no think about that |
@eliax1996 The beginning offset of the topic was mysteriously changing from 0 to the 2 (end offset) after a few seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using some (old) fixed timestamps when producing messages was causing the
messages to be automatically deleted because past message retention.
I think most of the time the test was managing to complete successfully
before the retention kicked in, making it fail only sometimes.