fix: proto3 optionals from base64 encoded proto descriptors #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keejon
force-pushed
the
keejon/fix-protobuf-optionals
branch
from
51cbe5f
to
766d129
Compare
This fixes deserialization of optionals in proto3 descriptors as they are represented by synthetic oneofs.
keejon
force-pushed
the
keejon/fix-protobuf-optionals
branch
from
766d129
to
7a3c839
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
eliax1996
reviewed
Oct 31, 2024
Comment on lines
+102
to
+107
| if is_proto3_optional: | ||
| # Every proto3 optional field is placed into a one-field oneof, called a "synthetic" oneof, | ||
| # as it was not present in the source .proto file. | ||
| # This will make sure that we don't interpret those optionals as oneof. | ||
| one_ofs[f.oneof_index] = None | ||
| fields.append(sf) |
There was a problem hiding this comment.
to be honest I don't really like the idea of marking the syntetic ones as None but I have no better ideas on how to keep the information in the type system 😄
Nice work! Thanks for the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes deserialization of optionals in proto3 descriptors as they are represented by synthetic oneofs.