Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Generate error codes from source #183

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

aiven-anton
Copy link
Collaborator

@aiven-anton aiven-anton commented May 30, 2024

Fixes #162.

@aiven-anton aiven-anton force-pushed the aiven-anton/generate-error-codes branch 2 times, most recently from a9a8027 to 454db59 Compare May 30, 2024 16:07
Base automatically changed from aiven-anton/official-docker-image to main May 31, 2024 12:38
@aiven-anton aiven-anton force-pushed the aiven-anton/generate-error-codes branch from 454db59 to 8063d23 Compare June 10, 2024 09:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7c0bda1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #183   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        14           
  Lines           ?       822           
  Branches        ?       132           
========================================
  Hits            ?       822           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-anton

This comment was marked as resolved.

@aiven-anton aiven-anton marked this pull request as ready for review June 10, 2024 10:20
@aiven-anton aiven-anton requested review from a team as code owners June 10, 2024 10:20
@aiven-anton
Copy link
Collaborator Author

Packaging metadata is failing due to upstream breakage in twine: pypa/twine#977

Copy link
Contributor

@giuseppelillo giuseppelillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@aiven-anton aiven-anton merged commit 4550cf9 into main Jun 26, 2024
11 of 12 checks passed
@aiven-anton aiven-anton deleted the aiven-anton/generate-error-codes branch June 26, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorCode has fallen out of sync with upstream
4 participants