Remove NodePrometheusRequestBuilder class #99
Comments
lukas-vlcek
added a commit
to lukas-vlcek/prometheus-exporter-plugin-for-opensearch
that referenced
this issue
Sep 6, 2022
This class is no longer needed because of refactoring that happened in the upstream in the past. Closes: Aiven-Open#99 --- Some details: 1. First the method `Action.newRequestBuilder(client)` was removed from Elasticsearch (see: elastic/elasticsearch#30966, specifically here elastic/elasticsearch@46e8d97#diff-34311f69b4f5ea90a3e88cabb8d3167f6c0651e5172f906750efc8a8276e4320L37). 2. Then it was removed from the Elasticsearch Prometheus exporter NodePrometheusMetricsAction class (see: vvanholl/elasticsearch-prometheus-exporter@deb496d#diff-d4bd29c3b4f015bf843e60db39c318a2560c6d9384942bbb271ed662ecf0d507L41). Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
NodePrometheusRequestBuilderclass is no longer needed because the method that was returning instance of this class has been removed from upstream classes (see below). Now, it is just a leftover from past refactoring and can be removed.First the method
Action.newRequestBuilder(client)was removed from Elasticsearch (see: Core: Remove RequestBuilder from Action elastic/elasticsearch#30966, specifically here elastic/elasticsearch@46e8d97#diff-34311f69b4f5ea90a3e88cabb8d3167f6c0651e5172f906750efc8a8276e4320L37).Then it was removed from the Elasticsearch Prometheus exporter NodePrometheusMetricsAction class (see: vvanholl/elasticsearch-prometheus-exporter@deb496d#diff-d4bd29c3b4f015bf843e60db39c318a2560c6d9384942bbb271ed662ecf0d507L41).
The text was updated successfully, but these errors were encountered: