feat: enhance Clippy linting directives #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes `to_radians` and `to_degrees` where possible I left many remaining ones that were ambiguous or harder to read with `mul_add`.
This has breaking changes.
This is a cool nursery lint that identifies places where `cbrt`, `hypot`, and `exp_m1` can be used.
The linter suggests one fix but the current way seems fine. Consider this a false positive. I added an allow attribute on the affected fn.
And for my final act, I introduce *lib.rs*.
|
Wow, an incredible amount of work has been done! After reviewing the contents of the commit, I think it can be merged. I will also add this to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new linting directives with pedantic and nursery groups.
It has been applied crate-wide, fixing a few hundred lints.
One lint rule, one commit.
Performance/accuracy:
mul_add,to_radians,to_degrees)cbrt,hypot,exp_m1)Control flow:
Breaking:
Some lints are skipped, as denoted in lib.rs with comments.
Closes #14