Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astrial Fruit is lost when the Ring of Seven Curses is wore after opening first end-city chest #538

Open
janhous233 opened this issue Dec 14, 2024 · 1 comment
Assignees
Labels
awaits review This issue was not yet reviewed by developer bug Something isn't working

Comments

@janhous233
Copy link

English is not my native language; please excuse typing errors.
I've posted my question in Chinese and English.

Problem Description:
When I wear the Ring of Seven Curses after opening the first end city chest, the astial fruit will not appear in the first end city chest I open after that.

问题描述:
当我在打开第一个末地城箱子后佩戴七咒之戒,天体果实将不会出现在我在此之后打开的第一个末地城箱子里

Version Information for minecraft and all installed mods:
版本信息:

  • Minecraft: 1.20.1
  • Forge: 47.3.5
  • Caelus: forge-3.2.0+1.20.1
  • Curios: forge-5.11.0+1.20.1
  • EnigmaticLegacy: 2.30.1
  • Patchouli: 1.20.1-84-FORGE

In detail, the game seeds and coordinates used for testing are as follows
详细的, 测试所使用的游戏种子和坐标如下
Seed: -7135716617475691255
Chest 1: -578 110 -919
Chest 2: -576 110 -917

@janhous233 janhous233 added awaits review This issue was not yet reviewed by developer bug Something isn't working labels Dec 14, 2024
@janhous233
Copy link
Author

A possible fix plan
Class: com.aizistral.enigmaticlegacy.objects.SpecialLootModifier
Line 88 ~ 94
from

if (!SuperpositionHandler.hasPersistentTag(player, "LootedFirstEndCityChest")) {
	SuperpositionHandler.setPersistentBoolean(player, "LootedFirstEndCityChest", true);

	if (SuperpositionHandler.isTheCursedOne(player)) {
		generatedLoot.add(new ItemStack(EnigmaticItems.ASTRAL_FRUIT, 1));
	}
}

to

if (!SuperpositionHandler.hasPersistentTag(player, "LootedFirstEndCityChest") && SuperpositionHandler.isTheCursedOne(player)) { // <-- Here
	SuperpositionHandler.setPersistentBoolean(player, "LootedFirstEndCityChest", true);
	generatedLoot.add(new ItemStack(EnigmaticItems.ASTRAL_FRUIT, 1));
}

janhous233 added a commit to janhous233/Enigmatic-Legacy.fork that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits review This issue was not yet reviewed by developer bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants