Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spinner when clicking a project #10

Merged

Conversation

microstudi
Copy link
Collaborator

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@microstudi microstudi merged commit e189334 into feature/bcn-budget-v0.24 Jun 1, 2021
aitorlb pushed a commit to Platoniq/decidim that referenced this pull request Jul 30, 2021
leio10 pushed a commit to decidim/decidim that referenced this pull request Sep 1, 2021
…8249)

* Scopes list improvements on the Budgets component landing page

AjuntamentdeBarcelona#1

* Add spinner when clicking a project

AjuntamentdeBarcelona#10

* Fix modal pop up when project exceeds budget amount

AjuntamentdeBarcelona#13

* Check amount in add to order command

AjuntamentdeBarcelona#14

* Fix 'Add line command'

AjuntamentdeBarcelona#15

* Restyle project vote button

AjuntamentdeBarcelona#16

* Change literal of button when budget is voted

AjuntamentdeBarcelona#17

* Show loading spinner only if no modals will open

5c47ca8

* Fix lint issue

* Fix more lint issues

* Fix lint ERB files errors

* Fix i18n-tasks unused

* Fix decidim-budgets/spec/system/orders_spec.rb

* Fix decidim-budgets/spec/system/explore_budgets_spec.rb

Co-authored-by: Vera Rojman <vera@platoniq.net>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: Vera Rojman <vrojman@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant