Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voted budgets and title bar hidden by focus mode #18

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

verarojman
Copy link

@verarojman verarojman commented Jun 21, 2021

  • Show voted budgets when voting finished TOCORE
  • Don't hide menu when focus mode not present

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@leio10 leio10 merged commit e9ee358 into release/0.24-stable-bcn Jun 21, 2021
@leio10 leio10 deleted the fix/show-voted-budgets branch June 21, 2021 15:28
leio10 pushed a commit that referenced this pull request Jun 30, 2021
Co-authored-by: Vera Rojman <vrojman@protonmail.com>
Co-authored-by: Vera Rojman <vera@platoniq.net>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>

bcn-budget-v0.24 to 0.24-stable-bcn (#12)

Fix modal pop up when project exceeds budget amount (#13)


Check amount in add to order command (#14)


Fix 'Add line command' (#15)


Restyle project vote button (#16)


Change literal of button when budget is voted (#17)


show loading spinner only if no modals will open

Fix voted budgets and title bar hidden by focus mode (#18)
leio10 pushed a commit that referenced this pull request Jul 22, 2021
Co-authored-by: Vera Rojman <vrojman@protonmail.com>
Co-authored-by: Vera Rojman <vera@platoniq.net>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>

bcn-budget-v0.24 to 0.24-stable-bcn (#12)

Fix modal pop up when project exceeds budget amount (#13)


Check amount in add to order command (#14)


Fix 'Add line command' (#15)


Restyle project vote button (#16)


Change literal of button when budget is voted (#17)


show loading spinner only if no modals will open

Fix voted budgets and title bar hidden by focus mode (#18)
microstudi added a commit that referenced this pull request Apr 5, 2022
* bcn-budget-v0.24 to 0.24-stable-bcn (#12)

Co-authored-by: Vera Rojman <vrojman@protonmail.com>
Co-authored-by: Vera Rojman <vera@platoniq.net>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>

* Fix modal pop up when project exceeds budget amount (#13)

* Check amount in add to order command (#14)

* Fix 'Add line command' (#15)

* Restyle project vote button (#16)

* Change literal of button when budget is voted (#17)

* show loading spinner only if no modals will open

* Fix voted budgets and title bar hidden by focus mode (#18)

Co-authored-by: Vera Rojman <vrojman@protonmail.com>
Co-authored-by: Vera Rojman <vera@platoniq.net>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants