[WIP] Copy: opt for sha256 instead of sha1 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ansible#82717 Co-authored-by: Karl A. Grindley <kgrindley@ll.mit.edu>
Handle errors raised when role doc has errors Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Handle AttributeError raised while running systemd facts on non-systemd hosts Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
The marker is removed in ansible-test managed environments, but the apt test restores it by installing/upgrading packages. To avoid breaking later tests, the marker needs to be removed again. ci_complete
ip_path is already calculated before calling get_interfaces_info Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com> Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
Fixes: ansible#83538 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
When releases are prepared, the upper bound on setuptools in pyproject.toml will be automatically updated to the latest version available on PyPI. This version will then be tested by the package-data sanity test during the release process and will be used to build the release. This change ensures that a released version of ansible-core can be built in the future if a new setuptools release includes breaking changes that would prevent building a functional package. If a downstream package maintainer requires a newer setuptools version than the upper bound permits, they can patch pyproject.toml as needed. Since ansible-core releases support specific Python versions, lack of support for new setuptools releases will have no effect on support for future Python versions.
add caplevel to display to pass through also reverse dict order as 'last update wins' added tests ... and also log severity to log Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* less confusing error msg * also remove 'removed' include
* Restore search path in the current task file’s directory for roles
…e#83729) * ansible-test - Update venv management * Upgrade from pip 24.0 to 24.2 * Omit `wheel` and `setuptools` from ansible-test managed virtual environments * Drop pre-release hacks * Update mypy requirements * Freeze sanity test requirements * Update sanity test configuration * Update sanity ignores
* package-data - Test min/max setuptools version * Fix multi-version abstraction * Convert mypy test to script based test * Fix f-string in pymarkdown test * Sanity test fixes
* hoping to improve CI stability
file was intended to be a string, not an undefined variable
* Add vaulted_file test * fix is_encrypted_file while we are here Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
adds color included configuration and applies to include message Co-authored-by: Achille Myette <amyette@drw.com>
* Enable validation of subkeys in rpm key module A gpg subkey may change while the primary key remains the same. Due to this behavior, there are situations where validation of the primary gpg key fingerprint is not sufficient because the desired target is actually the gpg subkey. This change allows the user to validate against either the fingerprint of the primary gpg key or its subkey. Signed-off-by: Kellin <kellin@retromud.org> * Improve tests, add multi-fingerprint - Improve tests to cover all cases - add multi fingerprint validation Signed-off-by: Kellin <kellin@retromud.org>
…#83718) * fix creating file in directory with setgid bit * add a test using the copy module's content option to create a file in a directory with setgid bit Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
Fixes: ansible#83214 --------- Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Jack Farzan <jfarzan@adobe.com>
--------- Co-authored-by: flowerysong <junk+github@flowerysong.com>
* Use sentinel everywhere Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Since we don't really care about the type we don't have to query for it and just retrieve the filename value. Unfortunately we cannot use module_utils.urls.get_response_filename as we don't have the response object, so just utilize email.message.Message to parse the filename instead of manually doing the work ourselves. Fixes: ansible#83690
* Remove unnecessary code * Make code simple to read Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This greatly reduces run time on large inventories since meta tasks are
executed in the main process sequentially and just executing them is expensive.
This change avoids running the following implicit meta tasks:
* ``flush_handlers`` on hosts where no handlers are notified
* ``noop`` for the linear strategy's lockstep, instead hosts that are
not executing the current task are just not part of the current host loop
A playbook consiting of two simple plays both running on ~6000 hosts
runs in:
devel: 37s
this PR: 1.3s
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
* ansible-test - Update sanity test requirements * ansible-test - Default to Python 3.13 in base/default containers * ansible-test - Fix incorrect AnyStr type hints
…ansible#83945) * Update unit test Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
…nsible#83332) * Fix installing collections|roles from git repos with GALAXY_IGNORE_CERTS * Fix installing collections from git repos with --ignore-certs * Update unit test * Add test case
... so strategies do not have to filter them.
add the `case_sensitive` setting
also added tests --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
* Correct case_sensitive example * Add attribute docs Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Added support for testing unit tests with mypy. * Added support for ignoring individual mypy error codes. * Added missing assert on unit tests and marked xfail. * Added type hints for some unit tests. * Added ignores for unit tests not passing mypy. * Fixed incorrect autouse argument in unit test fixtures. * Fixed minor issues causing problems with mypy in unit tests.
This cleans up the implementation of the pylint sanity test and enables the docstyle extension rule `bad-docstring-quotes` for tests. The rule will be enabled for the rest of ansible-core once automated cleanup has been performed on existing docstrings.
* Update triple single quotes to triple double quotes This change was fully automated. The updated Python files have been verified to tokenize the same as the originals, except for the expected change in quoting of strings, which were verified through literal_eval. * Manual conversion of docstring quotes
* Enable bad-docstring-quotes pylint rule for core * Ignore previously bulk update in git blame
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE