Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #9

Merged
merged 1 commit into from
Jan 28, 2023
Merged

update dependencies #9

merged 1 commit into from
Jan 28, 2023

Conversation

mistic100
Copy link
Contributor

@mistic100 mistic100 commented Jan 22, 2023

As promised here is the big update of dependencies.

It runned perfectly earlier today https://github.com/mistic100/Photo-Sphere-Viewer/actions/runs/3979342321/jobs/6821703153

Note that I also fixed some typos in the package.json


I am a bit dissapointed Github Actions requires to track the node modules, there 900k new LOC in this commit !!!

I didn't want to dig deeper but it seems people use bundlers like @vercel/ncc in order to produce lighter actions packages (see actions/hello-world-javascript-action#12)

@Akkjon Akkjon merged commit 18ff903 into Akkjon:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants