Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add presence check for childResourceType #6

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

MrSunshyne
Copy link
Contributor

@MrSunshyne MrSunshyne commented Nov 12, 2024

Solves #4

This PR resolves an issue where sometimes navigating within the GUI causes a blocking error with .fields being undefined. I'm not sure if this is fixing the issue itself or a side effect of the issue.

Note that Typescript is also complaining at this exact spot if you run it without the fix.

How to run locally ?

  1. Clone moquerie on your machine for example at /home/user/Projects/github.com/project-name/moquerie/
  2. Build moquerie : pnpm run build
  3. In the project where moquerie is being used update the scripts section in packages.json as follows to point towards your fork
scripts: {
    "dev:mock": "node /home/user/Projects/github.com/project-name/moquerie/packages/moquerie/bin.mjs",
    ...
 }

@MrSunshyne MrSunshyne changed the title bugfix: add presence check for childResourceType fix: add presence check for childResourceType Nov 12, 2024
@phsultan
Copy link

This indeed fixes it, thanks @MrSunshyne !

@TimvdEijnden
Copy link

@Akryum I'm also running into this issue, could it be possible to check and merge this fix maybe please?

@Akryum Akryum merged commit 8820fc3 into Akryum:main Dec 9, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants