Skip to content

fix observer null issue #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2019
Merged

Conversation

onmylife
Copy link
Contributor

After several routing, I saw some element occur null exception on $nextTick.
So I added checking logic for observer null or not.
if ovserver is null, call estoryObserver().

@ymchun
Copy link

ymchun commented Jan 15, 2019

@onmylife actually it's not necessary to call destroyObserver() since the error is thrown by previous observer instance (because of $nextTick) which is already destroy.

@ymchun
Copy link

ymchun commented Jan 15, 2019

@Akryum could you please merge this PR? Thank you!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@onmylife
Copy link
Contributor Author

onmylife commented Feb 8, 2019

@ymchun I agree. Destroy code is removed.

@zamarawka
Copy link

@Akryum could it be merged? I faced with this problem.

@KevinBon
Copy link

KevinBon commented Apr 25, 2019

I'm experiencing the same issue on this example.

The bug is triggered at the initialisation and when using the pagination.

@simllll
Copy link

simllll commented May 6, 2019

We just ran into the same issue, just saw this PR which is actually the same like #72 . What's the reason why this issue is not fixed yet?

@ymchun
Copy link

ymchun commented May 6, 2019

@simllll may be the author no longer maintaining this repo :(

@simllll
Copy link

simllll commented May 6, 2019

looks like this, therefore I just created @hokify/vue-observe-visibility@0.5.0

  • upgrades all deps (babel7,..etc)
  • fixed this bug

see https://github.com/hokify/vue-observe-visibility/commits/master

@Akryum Akryum merged commit 19dd03a into Akryum:master May 6, 2019
@Akryum
Copy link
Owner

Akryum commented May 6, 2019

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants