Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure items disable when hitting max. #1

Conversation

BenHenning
Copy link

@BenHenning BenHenning commented Dec 23, 2022

This PR updates oppia#4777 to ensure that the checkboxes are properly disabled when the max number of items is selected, and that they're visually updated to look disabled.

What it does not do that you'll need to do @Akshatkamboj14:

  • Check with the design team on which color should be used for the disabled version (the current color seems to have too poor of a contrast).
  • Update tests to verify that the behaviors are working as expected.
  • Add tests for the new AppCompatCheckBoxBindingAdapters in a similar way to other adapters tests.
  • Update 4777 to mark Introduce warning for selections oppia/oppia-android#3624 as fixed.

Note that I already checked the accessibility flow and it seems pretty solid.

Ensure checkboxes have a disabled color.
@BenHenning
Copy link
Author

PTAL @Akshatkamboj14.

@github-actions
Copy link

Thanks for submitting this pull request! Some main reviewers
have taken time off for the next few weeks, so it may take a
little while before we can look at this PR. We appreciate your
patience while some of our team members recharge. We'll be fully
returning on 10 January 2022.

@Akshatkamboj14 Akshatkamboj14 merged commit 3568c27 into Akshatkamboj14:ItemSelectionInteraction-text-change-and-checkboxes-should-be-disabled-on-selection Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants