-
Notifications
You must be signed in to change notification settings - Fork 689
Add date function to get current date without time component #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7ae7564
#1936 Add date function to get current date without time component
paulrutter 9202f79
#1936 Add date function to get current date without time component
paulrutter 8576258
#1936 Add date function to get current date without time component
paulrutter d768d84
- Fix running the parser in package.json
paulrutter a61ff2f
- Use tabs
paulrutter 10dddfd
Merge branch 'develop_2' into feature/add-curdate
paulrutter 4c12fbc
- Use alias to prevent duplicate code for CURRENT_DATE
paulrutter 1d41551
- Update dependencies
paulrutter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| if (typeof exports === 'object') { | ||
| var assert = require('assert'); | ||
| var alasql = require('..'); | ||
| } | ||
|
|
||
| describe('Test 1936 - Check CURDATE', function () { | ||
| it('CURDATE in SELECT - as Date', function () { | ||
| alasql.options.dateAsString = false; | ||
| let result = alasql("SELECT CURDATE AS date1, CURRENT_DATE AS date2, CURDATE(), CURRENT_DATE()"); | ||
|
|
||
| assert.ok(result[0]["date1"] instanceof Date); | ||
| assert.ok(result[0]["date1"].getHours() === 0); | ||
| assert.ok(result[0]["date1"].getMinutes() === 0); | ||
| assert.ok(result[0]["date1"].getSeconds() === 0); | ||
|
|
||
| assert.ok(result[0]["date2"] instanceof Date); | ||
| assert.ok(result[0]["date2"].getHours() === 0); | ||
| assert.ok(result[0]["date2"].getMinutes() === 0); | ||
| assert.ok(result[0]["date2"].getSeconds() === 0); | ||
|
|
||
| assert.ok(result[0]["CURDATE()"] instanceof Date); | ||
| assert.ok(result[0]["CURDATE()"].getHours() === 0); | ||
| assert.ok(result[0]["CURDATE()"].getMinutes() === 0); | ||
| assert.ok(result[0]["CURDATE()"].getSeconds() === 0); | ||
|
|
||
| assert.ok(result[0]["CURRENT_DATE()"] instanceof Date); | ||
| assert.ok(result[0]["CURRENT_DATE()"].getHours() === 0); | ||
| assert.ok(result[0]["CURRENT_DATE()"].getMinutes() === 0); | ||
| assert.ok(result[0]["CURRENT_DATE()"].getSeconds() === 0); | ||
| }); | ||
|
|
||
| it('CURDATE in SELECT - as String', function () { | ||
| alasql.options.dateAsString = true; | ||
| let result = alasql("SELECT CURDATE AS date1, CURRENT_DATE AS date2, CURDATE(), CURRENT_DATE()"); | ||
|
|
||
| assert.ok(typeof result[0]["date1"] === 'string'); | ||
| assert.ok(!result[0]["date1"].includes("00:00:00")); | ||
|
|
||
| assert.ok(typeof result[0]["date2"] === 'string'); | ||
| assert.ok(!result[0]["date2"].includes("00:00:00")); | ||
|
|
||
| assert.ok(typeof result[0]["CURDATE()"] === 'string'); | ||
| assert.ok(!result[0]["CURDATE()"].includes("00:00:00")); | ||
|
|
||
| assert.ok(typeof result[0]["CURRENT_DATE()"] === 'string'); | ||
| assert.ok(!result[0]["CURRENT_DATE()"].includes("00:00:00")); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.