Temporarily disable redirect tests due to HTTPBin issue #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain2540
added a commit
to rain2540/Alamofire
that referenced
this pull request
Aug 4, 2020
* origin/master: (193 commits) Use headers property. (Alamofire#3264) Prepare 5.2.2 Release (Alamofire#3262) Explicitly link CFNetwork when using SPM (Alamofire#3259) A Better debugDescription (Alamofire#3256) Add macOS(Catalyst) user agent. (Alamofire#3236) Temporarily disable redirect tests due to HTTPBin issue (Alamofire#3244) Replace if with switch in URLEncoding (Alamofire#3214) DataStreamRequest and test reliability fixes (Alamofire#3216) Open shouldRetry in RetryPolicy (Alamofire#3181) Prepare 5.2.1 (Alamofire#3208) Update .background QoS to .utility. (Alamofire#3207) Fix memory leaks (Alamofire#3199) Fix link in README. Prepare 5.2.0 Release (Alamofire#3189) More Flexible Response Handlers (Alamofire#3188) Minor documentation updates (Alamofire#3187) Fix Decimal encoding in URLEncodedFormEncoder. (Alamofire#3185) Fix threading issue: activeRequests could be accessed off of the rootQueue. (Alamofire#3179) Combine Support! (Alamofire#3160) Added AuthenticationInterceptor and Authenticator protocol (Alamofire#3164) ... # Conflicts: # .travis.yml # Alamofire.podspec # Alamofire.xcodeproj/project.pbxproj # Alamofire.xcodeproj/xcshareddata/xcschemes/Cleanup Whitespace.xcscheme # CHANGELOG.md # Documentation/AdvancedUsage.md # Example/Source/AppDelegate.swift # Example/Source/MasterViewController.swift # Example/iOS Example.xcodeproj/project.pbxproj # Example/iOS Example.xcodeproj/xcshareddata/xcschemes/iOS Example.xcscheme # Gemfile.lock # LICENSE # Package.swift # README.md # Source/Info.plist # Source/NetworkReachabilityManager.swift # Source/Request.swift # Source/Response.swift # Source/Result.swift # Source/ServerTrustPolicy.swift # Source/SessionManager.swift # Source/TaskDelegate.swift # Source/Timeline.swift # Source/Validation.swift # Tests/BaseTestCase.swift # Tests/NetworkReachabilityManagerTests.swift # Tests/ResponseSerializationTests.swift # Tests/ResultTests.swift # Tests/ServerTrustPolicyTests.swift # Tests/SessionManagerTests.swift # docs/Classes.html # docs/Classes/DataRequest.html # docs/Classes/DisabledEvaluator.html # docs/Classes/DownloadRequest.html # docs/Classes/DownloadRequest/Options.html # docs/Classes/MultipartFormData.html # docs/Classes/MultipartUpload.html # docs/Classes/NetworkReachabilityManager.html # docs/Classes/NetworkReachabilityManager/ConnectionType.html # docs/Classes/NetworkReachabilityManager/NetworkReachabilityStatus.html # docs/Classes/Request.html # docs/Classes/Request/ValidationResult.html # docs/Classes/SessionDelegate.html # docs/Classes/SessionManager.html # docs/Classes/SessionManager/MultipartFormDataEncodingResult.html # docs/Classes/UploadRequest.html # docs/Enums.html # docs/Enums/AFError.html # docs/Enums/AFError/MultipartEncodingFailureReason.html # docs/Enums/AFError/ParameterEncodingFailureReason.html # docs/Enums/AFError/ResponseSerializationFailureReason.html # docs/Enums/AFError/ResponseValidationFailureReason.html # docs/Enums/HTTPMethod.html # docs/Enums/Result.html # docs/Enums/ServerTrustPolicy.html # docs/Extensions.html # docs/Extensions/Bundle.html # docs/Extensions/DispatchQueue.html # docs/Extensions/Notification.html # docs/Extensions/Notification/Key.html # docs/Extensions/Notification/Name.html # docs/Extensions/Notification/Name/Task.html # docs/Extensions/SCNetworkReachabilityFlags.html # docs/Extensions/SecTrust.html # docs/Extensions/String.html # docs/Extensions/URL.html # docs/Extensions/URLComponents.html # docs/Extensions/URLRequest.html # docs/Functions.html # docs/Protocols.html # docs/Protocols/DataResponseSerializerProtocol.html # docs/Protocols/DownloadResponseSerializerProtocol.html # docs/Protocols/ParameterEncoding.html # docs/Protocols/RequestAdapter.html # docs/Protocols/RequestRetrier.html # docs/Protocols/SessionStateProvider.html # docs/Protocols/URLConvertible.html # docs/Protocols/URLRequestConvertible.html # docs/Structs.html # docs/Structs/DataResponse.html # docs/Structs/DownloadResponse.html # docs/Structs/HTTPMethod.html # docs/Structs/JSONEncoding.html # docs/Structs/URLEncoding.html # docs/Structs/URLEncoding/ArrayEncoding.html # docs/Structs/URLEncoding/BoolEncoding.html # docs/Structs/URLEncoding/Destination.html # docs/Typealiases.html # docs/badge.svg # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/DataRequest.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/DisabledEvaluator.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/DownloadRequest.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/DownloadRequest/Options.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/MultipartFormData.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/MultipartUpload.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/NetworkReachabilityManager.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/NetworkReachabilityManager/ConnectionType.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/NetworkReachabilityManager/NetworkReachabilityStatus.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/Request.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/Request/ValidationResult.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/SessionDelegate.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/SessionManager.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/SessionManager/MultipartFormDataEncodingResult.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Classes/UploadRequest.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/AFError.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/AFError/MultipartEncodingFailureReason.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/AFError/ParameterEncodingFailureReason.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/AFError/ResponseSerializationFailureReason.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/AFError/ResponseValidationFailureReason.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/HTTPMethod.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/Result.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Enums/ServerTrustPolicy.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/Bundle.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/DispatchQueue.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/Notification.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/Notification/Key.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/Notification/Name.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/Notification/Name/Task.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/SCNetworkReachabilityFlags.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/SecTrust.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/String.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/URL.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/URLComponents.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Extensions/URLRequest.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Functions.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/DataResponseSerializerProtocol.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/DownloadResponseSerializerProtocol.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/ParameterEncoding.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/RequestAdapter.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/RequestRetrier.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/SessionStateProvider.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/URLConvertible.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Protocols/URLRequestConvertible.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/DataResponse.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/DownloadResponse.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/HTTPMethod.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/JSONEncoding.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/URLEncoding.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/URLEncoding/ArrayEncoding.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/URLEncoding/BoolEncoding.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Structs/URLEncoding/Destination.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/Typealiases.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/index.html # docs/docsets/Alamofire.docset/Contents/Resources/Documents/search.json # docs/docsets/Alamofire.docset/Contents/Resources/Documents/undocumented.json # docs/docsets/Alamofire.docset/Contents/Resources/docSet.dsidx # docs/docsets/Alamofire.tgz # docs/docsets/Alamofire.xml # docs/index.html # docs/search.json # docs/undocumented.json # watchOS Example/watchOS Example WatchKit App/Info.plist # watchOS Example/watchOS Example WatchKit Extension/HostingController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
postmanlabs/httpbin#617
Goals ⚽
This PR disables our redirect tests while HTTPBin is returning a 404. This will also be fixed once we move to Firewalk for testing.
Implementation Details 🚧
Commented out all of the
RedirectHandlertests, underbarred the generalSessiontests.Testing Details 🔍
Tests should now pass.