Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auro design tokens: Gradient for Carousel and DatePicker #135

Closed
braven112 opened this issue Oct 30, 2023 · 0 comments · Fixed by #136
Closed

Auro design tokens: Gradient for Carousel and DatePicker #135

braven112 opened this issue Oct 30, 2023 · 0 comments · Fixed by #136
Assignees
@jordanjones243 @pgm369
Labels
design tokens Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Oct 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

We need the gradient used in auro-carousel and auro-datepicker to be a design token instead of a hard coded value. Currently the hardcoded value only works with white backgrounds but if the implementer is using this component on something other than white we want to implementer to be able to change this design token so that it can be blended in to any background as needed.

Describe the solution you'd like

A design token that can be scoped and overridden by the implementer as needed.

Describe alternatives you've considered

Just deal with an ugly experience.

Additional context

This design token will need to be used to fix this issue:
AlaskaAirlines/auro-carousel#32

The same value of this token should also be used but should have 2 separate token names so they can be altered independently.
AlaskaAirlines/auro-datepicker#150
@braven112 braven112 added Type: Feature New Feature design tokens not-reviewed Issue has not been reviewed by Auro team members labels Oct 30, 2023
@Patrick-Daly-AA Patrick-Daly-AA changed the title Auro design tokens: [feature summary] Auro design tokens: Gradient for Carousel and DatePicker Nov 1, 2023
pgm369 added a commit that referenced this issue Nov 3, 2023
@pgm369
feat(gradient): add new gradient background token #135
5ff297c
@pgm369 pgm369 mentioned this issue Nov 3, 2023
Merged
6 tasks
@pgm369 pgm369 linked a pull request Nov 3, 2023 that will close this issue
add new token for gradient #136
Merged
6 tasks
jordanjones243 pushed a commit that referenced this issue Nov 6, 2023
@pgm369 @jordanjones243
feat(gradient): add new gradient background token #135
075fa0d
jordanjones243 added a commit that referenced this issue Nov 6, 2023
@jordanjones243
feat(gradient): add new gradient token for white backgrounds #135
be128ac
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Nov 7, 2023
blackfalcon pushed a commit that referenced this issue Nov 7, 2023
@jordanjones243 @blackfalcon
feat(gradient): add new gradient token for white backgrounds #135
f6e99a4
blackfalcon pushed a commit that referenced this issue Nov 7, 2023
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
8b23154 
# [4.2.0](v4.1.1...v4.2.0) (2023-11-07)

### Features

* **base:** add new white tokens with different opacities ([b5a11d6](b5a11d6))
* **gradient:** add new gradient token for white backgrounds [#135](#135) ([f6e99a4](f6e99a4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

@pgm369 pgm369

Labels
design tokens Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new token for gradient AlaskaAirlines/AuroDesignTokens
4 participants
@blackfalcon @braven112 @jordanjones243 @pgm369