build(node-version): raised the minimum required node-version to v14 #148

B-E-A-F · 2022-11-10T02:00:27Z

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

I wanted to update svgo because in sdc we are getting warnings from one of it's dependencies. In order to update svgo we need to use Node 14, and in order to upgrade to Node 14 this project needed to update husky.

Fixes: #143 and #111

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

There are a lot of changes in this project, but they mostly have to do with package.json changes as well as husky pre-commit changes. I wanted to do the work to clean up the dependencies as much as possible, because as I said above I would love to update svgo.

I pinned the unreleased package @web/dev-server in case there is a version release that causes things to break.

I removed @semantic-release/npm because I noticed that it was already a dependency of @semantic-release.

I also updated @semantic-release as well as it's dependencies to the latest version since we can do that now that we only support Node 14 or higher.

I'm also following semver, for updating the package version to 5.0.0 because requiring Node 14 or higher is a breaking change.

Useful links:
https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v8

Type of change:

New capability
Revision of an existing capability
Infrastructure change (automation, etc.)
Other (please elaborate)

Checklist:

My update follows the CONTRIBUTING guidelines of this project
I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

MattSidor · 2022-11-10T17:26:35Z

Nice work, @mikearche.

It's not part of this PR, but related to your comment: I'm wondering if svgo should have been added as a devDependency instead of a dependency since it's not used by consumers of the library and they shouldn't need to worry about any warnings related to it? I'm not trying to imply that we shouldn't also consider updating it. (I am the one who added it, by the way.)

MattSidor · 2022-11-10T17:27:41Z

@mikearche When you get a chance, can you open a new issue for the svgo version warning?

B-E-A-F · 2022-11-10T17:51:53Z

I created an issue @MattSidor #149. I think we can also move it to a devDependency while that issue is being fixed as well.

blackfalcon

The following commands need to be run in order for Husky to run the pre-commit scripts.

chmod ug+x .husky/*
chmod ug+x .git/hooks/*

blackfalcon · 2022-11-14T21:49:48Z

package.json

@@ -1,27 +1,26 @@
 {
  "name": "@alaskaairux/icons",
  "description": "Alaska Air and Auro Design System Icons",
-  "version": "4.17.0",
+  "version": "5.0.0",


Please do not manually change the version number in the JSON file. This will get updated with the semantic release process.

Also, this does not warrant a MAJOR version release. This is not a feature release for the tool, but as you stated in the commit, this is a change to the build process.

Got it. I went ahead and removed the "BREAKING CHANGE" portion of the commit, and reverted package version change. I also force-pushed so the changes could be tracked with the existing commit. As far as the chmod changes, I went ahead and added it to the prepare script.

blackfalcon · 2022-11-14T22:36:58Z

SEMVER is only needed for customer-facing releases. This update has no effect to a consumer. Build changes are related to the repo and that is managed via Git versioning.

build(deps): bump husky from 4.3.8 to 8.0.2 build(deps): bump @commitlint/cli from 11.0.0 to 17.2.0 build(deps): bump @commitlint/config-conventional from 11.0.0 to 17.2.0 build(deps): bump @semantic-release/git from 9.0.1 to 10.0.1 build(deps): bump @semantic-release/changelog from 5.0.1 to 6.0.1 chore(deps): pin @web/dev-server to 0.1.31 perf(deps): remove unnecessary package @semantic-release/npm

blackfalcon · 2022-11-15T18:11:45Z

@mikearche can you add me to this repo? The Husky pre-commit is still not working.

hint: The '.husky/pre-commit' hook was ignored because it's not set as executable.
hint: The '.husky/commit-msg' hook was ignored because it's not set as executable.

blackfalcon · 2022-11-15T18:13:01Z

Also, we remove the Node 12.x test dependency

https://github.com/AlaskaAirlines/Icons/blob/master/.github/workflows/testPublish.yml#L18

B-E-A-F · 2022-11-15T18:49:51Z

@mikearche can you add me to this repo? The Husky pre-commit is still not working.
hint: The '.husky/pre-commit' hook was ignored because it's not set as executable.
hint: The '.husky/commit-msg' hook was ignored because it's not set as executable.

Interesting, the pre-commit hook is working for me. It could be a windows thing though. I shouldn't have any globally installed dependencies either. It fired off when I amended my commit. I added you to the repo.

Changes to be committed: modified: .husky/commit-msg modified: .husky/pre-commit

blackfalcon · 2022-11-15T19:06:10Z

@mikearche yeah, it's a linix thing

Changes to be committed: modified: .github/workflows/testPublish.yml

AuroDesignSystem · 2022-11-21T21:32:39Z

🎉 This PR is included in version 4.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

B-E-A-F requested a review from a team as a code owner November 10, 2022 02:00

blackfalcon requested changes Nov 14, 2022

View reviewed changes

blackfalcon assigned B-E-A-F Nov 14, 2022

This was linked to issues Nov 14, 2022

Update Husky to remove dependency on Node 12 #143

Closed

Update to latest version of Husky #111

Closed

blackfalcon mentioned this pull request Nov 14, 2022

SVGO dependency outputs warning on install #149

Closed

chore: update file permissions to run husky precommit

dfce4ea

Changes to be committed: modified: .husky/commit-msg modified: .husky/pre-commit

build: update actions dependencies

54ff30f

Changes to be committed: modified: .github/workflows/testPublish.yml

blackfalcon approved these changes Nov 15, 2022

View reviewed changes

blackfalcon merged commit c46017f into AlaskaAirlines:master Nov 15, 2022

blackfalcon deleted the marcher/huskyUpgrade/143 branch November 15, 2022 19:15

blackfalcon mentioned this pull request Nov 15, 2022

Update MAJOR ESM dependencies AlaskaAirlines/WC-Generator#203

Open

AuroDesignSystem added the released Completed work has been released label Nov 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(node-version): raised the minimum required node-version to v14 #148

build(node-version): raised the minimum required node-version to v14 #148

B-E-A-F commented Nov 10, 2022 •

edited by blackfalcon

Loading

MattSidor commented Nov 10, 2022

MattSidor commented Nov 10, 2022

B-E-A-F commented Nov 10, 2022

blackfalcon left a comment

blackfalcon Nov 14, 2022

B-E-A-F Nov 15, 2022 •

edited

Loading

blackfalcon commented Nov 14, 2022

blackfalcon commented Nov 15, 2022

blackfalcon commented Nov 15, 2022

B-E-A-F commented Nov 15, 2022

blackfalcon commented Nov 15, 2022

AuroDesignSystem commented Nov 21, 2022

build(node-version): raised the minimum required node-version to v14 #148

build(node-version): raised the minimum required node-version to v14 #148

Conversation

B-E-A-F commented Nov 10, 2022 • edited by blackfalcon Loading

Alaska Airlines Pull Request

Summary:

Type of change:

Checklist:

MattSidor commented Nov 10, 2022

MattSidor commented Nov 10, 2022

B-E-A-F commented Nov 10, 2022

blackfalcon left a comment

Choose a reason for hiding this comment

blackfalcon Nov 14, 2022

Choose a reason for hiding this comment

B-E-A-F Nov 15, 2022 • edited Loading

Choose a reason for hiding this comment

blackfalcon commented Nov 14, 2022

blackfalcon commented Nov 15, 2022

blackfalcon commented Nov 15, 2022

B-E-A-F commented Nov 15, 2022

blackfalcon commented Nov 15, 2022

AuroDesignSystem commented Nov 21, 2022

B-E-A-F commented Nov 10, 2022 •

edited by blackfalcon

Loading

B-E-A-F Nov 15, 2022 •

edited

Loading