Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating React components #265

Draft
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

blackfalcon
Copy link
Member

Alaska Airlines Pull Request

Resolves: #264

Summary:

This PR adds new functionality in the Generator script that will create a new file based on icons in the directory that defines new React specific components to allow for better React DX.

Type of change:

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@blackfalcon blackfalcon linked an issue Oct 4, 2024 that may be closed by this pull request
@blackfalcon blackfalcon changed the base branch from master to beta October 4, 2024 20:15
This commit adds new functionality in the Generator script that will
create a new file based on icons in the directory that defines new React
specific components to allow for better React DX.

On branch dsande/reactIcons/264
Changes to be committed:
modified:   scripts/generate.js
@blackfalcon blackfalcon force-pushed the dsande/reactIcons/264 branch from d5e574e to b6c0327 Compare October 4, 2024 20:17
@blackfalcon blackfalcon changed the title feat: add support for generating React components #264 Add support for generating React components Oct 4, 2024
blackfalcon and others added 3 commits October 4, 2024 13:34
This commit updates the README to include the following:

1. Remove legacy unsupported processes
2. Update to include new recommendations

On branch dsande/reactIcons/264
Changes to be committed:
modified:   README.md
This commit enhances the baseline react component support by providing
Typescript declarations for all icons within the repo.

On branch dsande/reactIcons/264
Your branch is up to date with 'origin/dsande/reactIcons/264'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icons: enhanced React SVG component support
2 participants