Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: marked npm package @latest breaks demo page #227

Closed
Eliza-Huang opened this issue Oct 7, 2021 · 1 comment
Closed

Generator: marked npm package @latest breaks demo page #227

Eliza-Huang opened this issue Oct 7, 2021 · 1 comment
Assignees
Labels
Type: Bug Bug or Bug fixes

Comments

@Eliza-Huang
Copy link

Eliza-Huang commented Oct 7, 2021

Describe the bug

When developing, the demo page that pops up is blank and there is an error in the console inside of devtools saying that marked from the marked npm package is not a function. There was a new version of marked released at around 1pm on 10/6/2021 and it's been broken since.

This only happens with components that are built using the WC Generator after this commit: 559b393#diff-38c424b322c7a39d8611e7d4df120ae548e41ed8efeee73bfe92c351fc880bfd.

To Reproduce

Steps to reproduce the behavior:

  1. Run npm run dev and npm run serve on any auro component.
  2. Wait for the demo page to pop up
  3. Notice that the page is blank and there's an error in the console

Expected behavior

The demo page pops up like it is supposed to.

Screenshots

image
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome (tested only in Chrome but should happen on all browsers)
  • Version 94

Additional context

Locking the marked version @3.0.4 in the file https://github.com/AlaskaAirlines/WC-Generator/blob/2d0867c7d6864908c86cc7948f4851f15615920d/template/demo/index.html should fix it.

@blackfalcon
Copy link
Member

Test the repo now. Marked had a bad release.

markedjs/marked#2226

There is no bug to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

3 participants