-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: use named exports only for ESM build #2226
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/7hqcLD8XkkvDd67KoNgefVcPbU9B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
No problem. Sorry I broke things |
Happens to all of us |
Hi guys, do you plan to release a patched version soon? Thx, |
🎉 This PR is included in version 3.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thx |
Marked version: 3.0.6
Markdown flavor: all
Description
Expectation
UMD build should have only default export for backwards compatibility. CJS cannot have both named and default exports like ESM can
Result
Backwards compatibility broke in UMD build
Contributor
Committer
In most cases, this should be a different person than the contributor.