Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #2223 #2224

Closed
wants to merge 1 commit into from
Closed

fix: revert #2223 #2224

wants to merge 1 commit into from

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Oct 6, 2021

It seems like #2223 turned lib/marked.js into a ES Module which would be a breaking change.

This reverts #2223

@vercel
Copy link

vercel bot commented Oct 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/B4Zp9q7u2BaXz2Rz6akyuxRMH18K
✅ Preview: https://markedjs-git-fork-uzitech-revert-2223-markedjs.vercel.app

@Conduitry
Copy link

Conduitry commented Oct 6, 2021

@UziTech
Copy link
Member Author

UziTech commented Oct 6, 2021

Object.defineProperty(exports, '__esModule', { value: true });

it is

@benmccann benmccann mentioned this pull request Oct 6, 2021
5 tasks
@benmccann
Copy link
Contributor

I'm not sure what issue you're seeing? As far as I know, I don't think there's any breaking change here. But if you'd like to remove that line, I think a better solution would be this: #2225

@UziTech UziTech closed this Oct 6, 2021
@UziTech
Copy link
Member Author

UziTech commented Oct 6, 2021

The breaking change is that methods like setOptions are not available on marked when including marked.min.js in a script tag like <script src="https://unpkg.com/marked@3.0.5/marked.min.js" async=""></script>

@UziTech UziTech reopened this Oct 6, 2021
@UziTech
Copy link
Member Author

UziTech commented Oct 6, 2021

looks like #2225 didn't fix it it only removed the __esModule property

@benmccann
Copy link
Contributor

I'm looking at this right now to see if there's a better fix now that I know how to reproduce the issue

@benmccann
Copy link
Contributor

Here's a fix for the issue: #2226

@UziTech UziTech closed this Oct 7, 2021
@UziTech UziTech deleted the revert-2223 branch November 21, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants