-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert #2223 #2224
fix: revert #2223 #2224
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/B4Zp9q7u2BaXz2Rz6akyuxRMH18K |
https://unpkg.com/marked@3.0.5/lib/marked.js / https://github.com/markedjs/marked/blob/v3.0.5/lib/marked.js doesn't look like an ESM file to me. |
it is |
I'm not sure what issue you're seeing? As far as I know, I don't think there's any breaking change here. But if you'd like to remove that line, I think a better solution would be this: #2225 |
The breaking change is that methods like |
looks like #2225 didn't fix it it only removed the |
I'm looking at this right now to see if there's a better fix now that I know how to reproduce the issue |
Here's a fix for the issue: #2226 |
It seems like #2223 turned lib/marked.js into a ES Module which would be a breaking change.
This reverts #2223