Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move auro-library into devDependencies in template file #577

Closed
chrisfalaska opened this issue Oct 10, 2024 · 0 comments · Fixed by #578
Closed

Move auro-library into devDependencies in template file #577

chrisfalaska opened this issue Oct 10, 2024 · 0 comments · Fixed by #578
Assignees
@chrisfalaska
Labels
wc-generator

Comments

@chrisfalaska
Copy link
Contributor

chrisfalaska commented Oct 10, 2024 •
edited
Loading

Please verify the version of WCGenerator you have installed

4.6.1

Please describe the bug

Similar to the issue raised in #575 , the template file needs to be updated to move @aurodesignsystem/auro-library into package.json devDependencies

  1. Open package.json
  2. Note that "@aurodesignsystem/auro-library": "^2.8.0", is listed inside devDependencies

Reproducing the error

None

Expected behavior

To avoid issues when installing into projects, Auro Library needs to be listed as part of dependencies.

What browsers are you seeing the problem on?

No response

Additional context

First reported in #573

Exit criteria

  1. Auro Library listed in dependencies
  2. build runs correctly
  3. tests pass
@chrisfalaska chrisfalaska added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members wc-generator labels Oct 10, 2024
@chrisfalaska chrisfalaska removed Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members labels Oct 10, 2024
chrisfalaska added a commit that referenced this issue Oct 10, 2024
@chrisfalaska
fix: moves auro library in template to dependencies #577
e46ebdd
@chrisfalaska chrisfalaska mentioned this issue Oct 10, 2024
Merged
3 tasks
@chrisfalaska chrisfalaska linked a pull request Oct 10, 2024 that will close this issue
fix: moves auro-library in template to dependencies #577 #578
Merged
3 tasks
chrisfalaska added a commit that referenced this issue Oct 10, 2024
@chrisfalaska
fix: moves auro library in template to dependencies #577
cdc46fd
blackfalcon pushed a commit that referenced this issue Oct 10, 2024
@semantic-release-bot
chore(release): 4.6.2 [skip ci]
5a5c184 
## [4.6.2](v4.6.1...v4.6.2) (2024-10-10)

### Bug Fixes

* moves auro library in template to dependencies [#577](#577) ([cdc46fd](cdc46fd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisfalaska chrisfalaska

Labels
wc-generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: moves auro-library in template to dependencies #577 AlaskaAirlines/WC-Generator
2 participants
@Patrick-Daly-AA @chrisfalaska