Update inefficient RegEx #357 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fajar-apri-alaska
force-pushed
the
fajarapri/inefficientRegex
branch
from
2ed4729 to
7848202
Compare
- Update below regex to make it more efficient: \r\n|\r|\n -> \r?\n|\r(?!\n) 1. The \r\n is redundant to \r checking in current pattern, and I think we can combine it with the \n checking by using \r?\n 2. At first, I want to also remove the standalone \r because it only for older Mac OS, but I think we should keep it for backward compatibility, so adding | \r to the pattern. 3. Additional (?!\n) in the end is to make sure the \r is not followed by \n, to avoid exponential backtracking on strings starting with ''' and containing many repetitions of '\r\n'. (per latest [CodeQL analysis alert](https://github.com/AlaskaAirlines/WC-Generator/security/code-scanning/3)) Changes to be committed: modified: package-lock.json modified: template/scripts/generateDocs.mjs
fajar-apri-alaska
force-pushed
the
fajarapri/inefficientRegex
branch
from
7848202 to
ce69d1e
Compare
blackfalcon
approved these changes
Feb 2, 2024
|
🎉 This PR is included in version 4.4.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #357
Summary:
\r\n|\r|\n -> \r?\n|\r(?!\n)
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team