Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #108

Closed
2 tasks
jordanjones243 opened this issue Mar 11, 2024 · 2 comments
Closed
2 tasks

Update color tokens for theming support #108

jordanjones243 opened this issue Mar 11, 2024 · 2 comments
Labels
auro-accordion not-reviewed Issue has not been reviewed by Auro team members Type: Design New or related Design work Type: Feature New Feature

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 11, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Design New or related Design work Type: Question Type: Feature New Feature auro-accordion not-reviewed Issue has not been reviewed by Auro team members labels Mar 11, 2024
@jordanjones243
Copy link
Contributor Author

Tokens to be changed:

  • transparent

Rules that need refinement:

  • All background-color and color rules. Do we need to use linear-gradient instead?
  • background-color: var(--ds-color-border-active-default, $ds-color-border-active-default);
  • All border rules. Do we want to use a token for the entire rule or a tokens for each part of the rule (e.g. a rule for px size, type of border line and color)

@jordanjones243
Copy link
Contributor Author

This ticket will be blocked until this work is completed:

@jordanjones243 jordanjones243 removed their assignment Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-accordion not-reviewed Issue has not been reviewed by Auro team members Type: Design New or related Design work Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants