Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot contents push screen width even when collapsed #46

Closed
gusnaughton opened this issue Feb 3, 2022 · 1 comment · Fixed by #48
Closed

Slot contents push screen width even when collapsed #46

gusnaughton opened this issue Feb 3, 2022 · 1 comment · Fixed by #48
Assignees
@blackfalcon
Labels
auro-accordion Type: Bug Bug or Bug fixes
Milestone
auro-accordion bugs

Comments

@gusnaughton
Copy link
Member

Describe the bug

accordionbug.mov

To Reproduce

place and static width object inside the accordion slot

Expected behavior

I expect the screen width to only be consumed when the slot is expanded

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.
@gusnaughton gusnaughton added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members labels Feb 3, 2022
@gusnaughton
Copy link
Member Author

FYI @erikalanghauser

@blackfalcon blackfalcon added auro-accordion and removed not-reviewed Issue has not been reviewed by Auro team members labels Feb 3, 2022
blackfalcon added a commit that referenced this issue Feb 4, 2022
@blackfalcon
feat(cssparts): add support to customize content area #46
a33f3a2 
Multiple PRs have been created (#33,#40) to help support custom content.
The issue remains that this issue is too difficult to manage this way
and a third issue was created to support the exact same scenario.

As the maintainer of a design system, trying to support all styles of
content is not possible. We can do our best to support use cases
that we are aware of, but in the case where the content does not
fit the model we support, we must allow out users a way to customize
per their content, and that is the role of CSS Parts.

Changes to be committed:
modified:   demo/index.html
modified:   docs/api.md
modified:   src/auro-accordion.js
modified:   src/style.scss
@blackfalcon blackfalcon mentioned this issue Feb 4, 2022
Merged
6 tasks
blackfalcon added a commit that referenced this issue Feb 4, 2022
@blackfalcon
feat(cssparts): add support to customize content area #46
f0e6630 
Multiple PRs have been created (#33,#40) to help support custom content.
The issue remains that this issue is too difficult to manage this way
and a third issue was created to support the exact same scenario.

As the maintainer of a design system, trying to support all styles of
content is not possible. We can do our best to support use cases
that we are aware of, but in the case where the content does not
fit the model we support, we must allow our users a way to customize
per their content, and that is the role of CSS Parts.

Changes to be committed:
modified:   demo/index.html
modified:   docs/api.md
modified:   src/auro-accordion.js
modified:   src/style.scss
@blackfalcon blackfalcon linked a pull request Feb 4, 2022 that will close this issue
Add support to customize content area #48
Merged
6 tasks
@braven112 braven112 added this to the auro-accordion bugs milestone Feb 7, 2022
blackfalcon added a commit that referenced this issue Feb 8, 2022
@blackfalcon
feat(cssparts): add support to customize content area #46
71ed7ce 
Multiple PRs have been created (#33,#40) to help support custom content.
The issue remains that this issue is too difficult to manage this way
and a third issue was created to support the exact same scenario.

As the maintainer of a design system, trying to support all styles of
content is not possible. We can do our best to support use cases
that we are aware of, but in the case where the content does not
fit the model we support, we must allow our users a way to customize
per their content, and that is the role of CSS Parts.

Changes to be committed:
modified:   demo/index.html
modified:   docs/api.md
modified:   src/auro-accordion.js
modified:   src/style.scss
@blackfalcon blackfalcon changed the title auro-accordion: Slot contents push screen width even when collapsed Slot contents push screen width even when collapsed Feb 8, 2022
AuroDesignSystem pushed a commit that referenced this issue Feb 8, 2022
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
42582b7 
# [1.6.0](v1.5.1...v1.6.0) (2022-02-08)

### Features

* **cssparts:** add support to customize content area [#46](#46) ([71ed7ce](71ed7ce)), closes [#33](#33) [#40](#40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-accordion Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
auro-accordion bugs
Development

Successfully merging a pull request may close this issue.

Add support to customize content area AlaskaAirlines/auro-accordion
3 participants
@blackfalcon @braven112 @gusnaughton