-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add register static method #69 #70 #73
Conversation
- Update dependency versions - `AuroAlert.register` is to easily register the element without extra importing - `import "@aurodesignsystem/auro-alert"` will still register this element to <auro-alert> - `import { AuroAlert } from '../src/auro-alert.js` wont register this element until `AuroAlert.register` gets called
Reviewer's Guide by SourceryThis PR introduces a new static Class diagram for AuroAlert with new register methodclassDiagram
class AuroAlert {
+static register(name="auro-alert")
+firstUpdated()
+render()
}
note for AuroAlert "The register method allows custom element registration."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #70 #69
Summary:
AuroAlert.register
is to easily register the element without extra importingimport "@aurodesignsystem/auro-alert"
will still register this element toimport { AuroAlert } from '../src/auro-alert.js
wont register this element untilAuroAlert.register
gets calledType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a static method
AuroAlert.register
to facilitate element registration, update dependencies, and adjust the build configuration to include demo scripts.New Features:
AuroAlert.register
to allow easy registration of the element without extra importing.Enhancements:
Build:
index.min.js
andapi.min.js
.Documentation:
AuroAlert.register
method for registering custom elements.