-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update import and Sass var reference #75 #76
Conversation
Reviewer's Guide by SourceryThe changes focus on optimizing Sass/CSS variable handling by removing a redundant design token import and fixing a Sass variable interpolation issue. The implementation updates how Sass variables are processed into CSS values using proper interpolation syntax. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Output CSS is validated [auro-icon] {
--ds-auro-icon-size: var(--ds-size-300, 1.5rem);
margin-right: var(--ds-size-100, 0.5rem);
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blackfalcon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This commit removes an unnecessary import of design tokens into the local scope. It also updates a Sass variable reference to use interpolation to process the Sass variable into a CSS value. On branch dsande/sassError Changes to be committed: modified: demo/api.min.js modified: demo/index.min.js modified: src/style.scss
155d20a
to
75a037e
Compare
🎉 This PR is included in version 3.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #75
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
This commit removes an unnecessary import of design tokens into the local scope. It also updates a Sass variable reference to use interpolation to process the Sass variable into a CSS value.
On branch dsande/sassError
Changes to be committed:
modified: demo/api.min.js
modified: demo/index.min.js
modified: src/style.scss
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Fix import and Sass variable reference by removing an unnecessary import and updating a Sass variable to use interpolation for CSS value processing.
Bug Fixes:
Enhancements: