Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update import and Sass var reference #75 #76

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Oct 31, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #75

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This commit removes an unnecessary import of design tokens into the local scope. It also updates a Sass variable reference to use interpolation to process the Sass variable into a CSS value.

On branch dsande/sassError
Changes to be committed:
modified: demo/api.min.js
modified: demo/index.min.js
modified: src/style.scss

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix import and Sass variable reference by removing an unnecessary import and updating a Sass variable to use interpolation for CSS value processing.

Bug Fixes:

  • Remove unnecessary import of Sass custom properties to prevent redundant code inclusion.

Enhancements:

  • Update Sass variable reference to use interpolation for processing into a CSS value.

Copy link

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

The changes focus on optimizing Sass/CSS variable handling by removing a redundant design token import and fixing a Sass variable interpolation issue. The implementation updates how Sass variables are processed into CSS values using proper interpolation syntax.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed redundant design tokens import
  • Removed unnecessary import of SassCustomProperties tokens as they were not needed in the local scope
src/style.scss
Fixed Sass variable interpolation in CSS custom property fallback
  • Added proper Sass interpolation syntax (#{}) to process $ds-size-300 variable into a CSS value
  • Ensures correct compilation of Sass variable into CSS custom property fallback value
src/style.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@blackfalcon
Copy link
Member Author

Output CSS is validated

[auro-icon] {
  --ds-auro-icon-size: var(--ds-size-300, 1.5rem);
  margin-right: var(--ds-size-100, 0.5rem);
}

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blackfalcon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

demo/api.min.js Outdated Show resolved Hide resolved
demo/index.min.js Outdated Show resolved Hide resolved
@blackfalcon blackfalcon self-assigned this Oct 31, 2024
@blackfalcon blackfalcon requested a review from rmenner October 31, 2024 17:58
@blackfalcon blackfalcon linked an issue Oct 31, 2024 that may be closed by this pull request
jason-capsule42
jason-capsule42 previously approved these changes Nov 5, 2024
This commit removes an unnecessary import of design tokens into the
local scope. It also updates a Sass variable reference to use
interpolation to process the Sass variable into a CSS value.

On branch dsande/sassError
Changes to be committed:
modified:   demo/api.min.js
modified:   demo/index.min.js
modified:   src/style.scss
@jason-capsule42 jason-capsule42 merged commit 25c6229 into main Nov 5, 2024
6 checks passed
@jason-capsule42 jason-capsule42 deleted the dsande/sassError branch November 5, 2024 01:16
@blackfalcon
Copy link
Member Author

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary tokens inclusion, incorrect Sass reference
2 participants