feat: update auro-library to 3.0.1 #84
Conversation
Reviewer's Guide by SourceryThis PR updates the auro-library dependency to version 3.0.1 and updates documentation file paths to match the new structure. The changes primarily involve updating relative path references in various markdown files to ensure proper content generation. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @DukeFerdinand - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -248,7 +248,7 @@ var colorCss$1 = i$3`:host{color:var(--ds-auro-icon-color)}:host([customColor]){ | |||
|
|
|||
| /* eslint-disable line-comment-position, no-inline-comments, no-confusing-arrow, no-nested-ternary, implicit-arrow-linebreak */ | |||
|
|
|||
| class AuroLibraryRuntimeUtils { | |||
| let AuroLibraryRuntimeUtils$1 = class AuroLibraryRuntimeUtils { | |||
There was a problem hiding this comment.
issue (complexity): Consider optimizing the build configuration to prevent duplicate class definitions
The duplicate AuroLibraryRuntimeUtils class definition appears to be an artifact of the build/bundling process rather than intentional code duplication. This should be addressed through build optimization rather than code changes.
Consider:
- Review your bundler configuration to enable code deduplication
- If using Rollup, enable the
dedupeoption:
// rollup.config.js
export default {
plugins: [
resolve({
dedupe: ['AuroLibraryRuntimeUtils']
})
]
}- If using Webpack, verify ModuleConcatenationPlugin is enabled for production builds:
// webpack.config.js
module.exports = {
optimization: {
concatenateModules: true
}
}| : found | ||
| ? found // found a selector INside this element | ||
| : __Closest(el.getRootNode().host) // recursion!! break out to parent DOM |
There was a problem hiding this comment.
suggestion (code-quality): Avoid unneeded ternary statements (simplify-ternary)
| : found | |
| ? found // found a selector INside this element | |
| : __Closest(el.getRootNode().host) // recursion!! break out to parent DOM | |
| : found || __Closest(el.getRootNode().host) // recursion!! break out to parent DOM | |
Explanation
It is possible to simplify certain ternary statements into either use of an|| or !.This makes the code easier to read, since there is no conditional logic.
| : found | ||
| ? found // found a selector INside this element | ||
| : __Closest(el.getRootNode().host) // recursion!! break out to parent DOM |
There was a problem hiding this comment.
suggestion (code-quality): Avoid unneeded ternary statements (simplify-ternary)
| : found | |
| ? found // found a selector INside this element | |
| : __Closest(el.getRootNode().host) // recursion!! break out to parent DOM | |
| : found || __Closest(el.getRootNode().host) // recursion!! break out to parent DOM | |
Explanation
It is possible to simplify certain ternary statements into either use of an|| or !.This makes the code easier to read, since there is no conditional logic.
jordanjones243
force-pushed
the
dhook/update-auro-library
branch
from
c39947d to
263cf71
Compare
The docsite example is broken, the localhost is correct. |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #83
Summary:
This updates to the latest auro-library version and ensures the documentation paths are updated in
index.mdandapi.mdto match!Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update auro-library to version 3.0.1 and adjust documentation paths to match the new directory structure.
New Features:
Documentation: