Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #86

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update project settings and configurations to support Node.js v22. Update documentation to reflect the changes. Update CI workflows to test on Node.js v22 instead of v18.

Build:

  • Update Node.js version to v22

CI:

  • Test on Node.js v22 instead of v18

Documentation:

  • Update contributing guidelines with innersourcing information, rebase instructions, conventional commit guidelines, and issue submission process. Update issue templates with exit criteria and labels. Update code of conduct contact information.

@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the Auro project to use Node.js v22 and includes general updates to the project documentation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Node version
  • Updated Node version to v22 in all workflows and configuration files.
  • Updated package.json and package-lock.json to reflect the new Node version
.github/settings.yml
.github/workflows/testPublish.yml
package.json
package-lock.json
Updated repository settings
  • Enabled automatic deletion of branches on merge.
  • Added Auro team and non-Auro team with write access to teams settings
.github/settings.yml
Updated contributing guidelines
  • Added Innersourcing Flow Guide link for Alaska Airlines employees.
  • Clarified issue submission process.
  • Added instructions on rebasing and avoiding git pull on feature branches.
  • Updated guidance on conventional commits and commit message format
.github/CONTRIBUTING.md
Updated issue templates
  • Added exit criteria section to all issue templates
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Added publish demo workflow
  • Created new workflow to publish demo on pull request to main branch
.github/workflows/publishDemo.yml
Added CODEOWNERS file
  • Created CODEOWNERS file
.github/CODEOWNERS
Updated other files
  • Minor updates to improve clarity and accuracy of documentation
.github/CODE_OF_CONDUCT.md
.github/PULL_REQUEST_TEMPLATE.md
.github/stale.yml
.github/workflows/codeql.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge #85

@jason-capsule42 jason-capsule42 force-pushed the migration/package-update/node-v22 branch from 3862d89 to f095908 Compare December 21, 2024 00:17
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 21, 2024 00:17
@jason-capsule42 jason-capsule42 merged commit c03ca18 into main Dec 21, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-v22 branch December 21, 2024 00:19
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
3 participants