Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-badge: update Sass to use dart-sass dependency #42

Closed
blackfalcon opened this issue Apr 6, 2023 · 1 comment · Fixed by #45
Closed

auro-badge: update Sass to use dart-sass dependency #42

blackfalcon opened this issue Apr 6, 2023 · 1 comment · Fixed by #45
Assignees
@blackfalcon
Milestone
Badge: Node 18+ s...

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

The current version of the element is still dependent on a legacy version of node-sass that will not run on any version of Node greater than 14. Any legacy Orion dependencies should be replaced with current Auro versions.

Describe the solution you'd like

Update this repo to use dart-sass.

Sass is not a direct dependency. Auro elements use wc-sass-render which has a nested dependency on dart-sass. There is no need to install Sass directly.

  1. node-sass to dart-sass
  2. remove any dependency on any legacy Orion components

Context

This issue is related to the following reported issue:

Exit criteria

This issue will not be considered complete once the listed core features are updated along with all associated dependencies and all features work as previously expected with node 18 installed.
@blackfalcon blackfalcon added this to the Badge: Node 18+ support milestone Apr 6, 2023
@blackfalcon blackfalcon self-assigned this Apr 6, 2023
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(sass): update to dart-sass #42
fc0cd44 
Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(sass): update to dart-sass #42
c77062e 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
@blackfalcon blackfalcon linked a pull request Apr 6, 2023 that will close this issue
Node 18+ updates #45
Merged
6 tasks
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(sass): update to dart-sass #42
c217416 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(sass): update to dart-sass #42
d167bc0 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
@blackfalcon blackfalcon mentioned this issue Apr 6, 2023
Merged
6 tasks
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(sass): update to dart-sass #42
2733a16 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Apr 7, 2023
@blackfalcon
perf(sass): update to dart-sass #42
bc9d72e 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Apr 9, 2023
@blackfalcon
perf(sass): update to dart-sass #42
f1edf77 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue Apr 9, 2023
Closed
@AuroDesignSystem AuroDesignSystem mentioned this issue Apr 10, 2023
Closed
blackfalcon added a commit that referenced this issue Apr 13, 2023
@blackfalcon
perf(sass): update to dart-sass #42
d8f40ff 
This step requires the removal of
node 11 and 12 remote testing.

Changes to be committed:
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
modified:   src/style.scss
blackfalcon pushed a commit that referenced this issue Apr 13, 2023
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
61190a7 
# [2.0.0](v1.2.4...v2.0.0) (2023-04-13)

### Documentation

* **npm:** update npm namespace [#37](#37) ([ebe7baa](ebe7baa))

### Features

* **ts:** add support for typescript users [#39](#39) ([6d960f0](6d960f0))

### Performance Improvements

* **demo styles:** remove local dependency [#34](#34) ([8d3dc13](8d3dc13))
* **es5:** remove legacy bundle build process [#35](#35) ([5166da4](5166da4))
* **extend:** move customElements.define function to root [#44](#44) ([44ad8c8](44ad8c8))
* **husky:** update to current version [#43](#43) ([f14f563](f14f563))
* **lit:** update component to Lit2.0 [#32](#32) ([2dbf150](2dbf150))
* **node18:** update repo to support Node 18+ [#31](#31) ([8617c36](8617c36))
* **postCss:** remove legacy build services [#40](#40) ([651fcb7](651fcb7))
* **sass:** update to dart-sass [#42](#42) ([d8f40ff](d8f40ff))
* **server:** update to use single shell [#33](#33) ([181aba8](181aba8))

### BREAKING CHANGES

* **npm:** This update will redefine the npm namespace
for the auro-badge element.

Changes to be committed:
modified:   README.md
modified:   package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
None yet
Projects
None yet
Milestone
Badge: Node 18+ support
Development

Successfully merging a pull request may close this issue.

Node 18+ updates AlaskaAirlines/auro-badge
1 participant
@blackfalcon