Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus-visible code is missing #127

Closed
blackfalcon opened this issue Mar 12, 2024 · 2 comments · Fixed by #130
Closed

focus-visible code is missing #127

blackfalcon opened this issue Mar 12, 2024 · 2 comments · Fixed by #130
Labels
auro-checkbox

Comments

@blackfalcon
Copy link
Member

Please verify the version of auro-checkbox you have installed

@latest

Please describe the bug

  1. Go to https://auro.alaskaair.com/components/auro/checkbox
  2. Tab through the UI
  3. See error

Notice that you are not seeing any UI feedback from tabbing onto any of the check box items.

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

All interactive elements should support :focus-visible as an accessible interactive affordance on the element.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

It appears that with a large CSS refactor the .focus-visible selector was deleted versus being refactored to support the :focus-visible pseudo selector.

https://github.com/AlaskaAirlines/auro-checkbox/pull/114/files#diff-f1b002481f489a1e54abd539b444b29f9b5f909946f4fe17344c5a266a0ff6d1

Exit criteria

This issue can be closed once the checkbox element illustrates the proper UI feedback when tabbing to the element on a page.
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members auro-checkbox labels Mar 12, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Mar 15, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Mar 15, 2024
@jordanjones243 jordanjones243 self-assigned this Apr 29, 2024
jordanjones243 added a commit that referenced this issue Apr 29, 2024
@jordanjones243
fix(border): update focus border styles #127
c127842
jordanjones243 added a commit that referenced this issue Apr 29, 2024
@jordanjones243
fix(border): update focus border styles #127
0b5b366
@jordanjones243 jordanjones243 linked a pull request Apr 30, 2024 that will close this issue
Implement formvalidation repo #130
Merged
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Apr 30, 2024
Merged
6 tasks
jordanjones243 added a commit that referenced this issue May 1, 2024
@jordanjones243
fix(border): update focus border styles #127
39c9e2d
jordanjones243 added a commit that referenced this issue May 10, 2024
@jordanjones243
fix(border): update focus border styles #127
1cbbf0c
jason-capsule42 pushed a commit that referenced this issue May 10, 2024
@jordanjones243 @jason-capsule42
fix(border): update focus border styles #127
9d10251
blackfalcon pushed a commit that referenced this issue May 10, 2024
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
37610b9 
# [3.0.0](v2.1.8...v3.0.0) (2024-05-10)

### Bug Fixes

* **border:** update focus border styles [#127](#127) ([9d10251](9d10251))

### Features

* **library:** add auro-library functionality to repo ([99ee3c6](99ee3c6))
* **validation:** implement formvalidation repo [#129](#129) ([c8a45be](c8a45be))

### Performance Improvements

* **deps:** update dependencies ([88e0b3b](88e0b3b))
* **validation:** update validation logic for checkbox border [#129](#129) ([4b85ab1](4b85ab1))
* **validity:** update tests and validation for error and required [#129](#129) ([0b833e5](0b833e5))

### BREAKING CHANGES

* **validation:** The individual component validation, as well as support for individual checkboxes using the required attribute has been removed.
@jordanjones243
Copy link
Contributor

Re-opening this ticket, as the change in the v3.0 was incorrect:

The change should involve the focus-visible selector, not focus-within

@jordanjones243 jordanjones243 removed their assignment May 13, 2024
@jason-capsule42 jason-capsule42 removed the Type: Bug Bug or Bug fixes label Oct 3, 2024
@jason-capsule42
Copy link
Member

This was fixed as part of the theme work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-checkbox
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement formvalidation repo AlaskaAirlines/auro-checkbox
4 participants
@blackfalcon @jason-capsule42 @jordanjones243 @Patrick-Daly-AA