Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-checkbox: properties need to be reflected and have default values #19

Closed
geoffrich opened this issue May 25, 2021 · 1 comment · Fixed by #27
Closed

auro-checkbox: properties need to be reflected and have default values #19

geoffrich opened this issue May 25, 2021 · 1 comment · Fixed by #27
Assignees
@geoffrich
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@geoffrich
Copy link
Contributor

Describe the bug

The following checkbox-group properties are used for styling and are not reflected:

  • error
  • disabled

In addition, the following boolean properties need a default value:

  • required (checkbox)
  • disabled, horizontal, required (checkbox-group)

These prevent the component from behaving property in a Svelte app.

Expected behavior

The above properties are reflected and have default values, where necessary.
@geoffrich geoffrich added the Type: Bug Bug or Bug fixes label May 25, 2021
@geoffrich geoffrich self-assigned this May 25, 2021
@blackfalcon blackfalcon removed their assignment May 27, 2021
@geoffrich geoffrich added the Status: Work In Progress Issue or Pull Request work is in Progress label Aug 2, 2021
@geoffrich geoffrich mentioned this issue Aug 2, 2021
Merged
3 tasks
geoffrich added a commit that referenced this issue Aug 3, 2021
@geoffrich
fix: reflect and set default boolean props #19
2883cbf
blackfalcon pushed a commit that referenced this issue Aug 3, 2021
@geoffrich @blackfalcon
fix: reflect and set default boolean props #19
ecf8645
AuroDesignSystem pushed a commit that referenced this issue Aug 3, 2021
@semantic-release-bot
chore(release): 1.1.3 [skip ci]
d420b6e 
## [1.1.3](v1.1.2...v1.1.3) (2021-08-03)

### Bug Fixes

* reflect and set default boolean props [#19](#19) ([ecf8645](ecf8645))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 1.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrich geoffrich

Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reflect and set default boolean props AlaskaAirlines/auro-checkbox
3 participants
@blackfalcon @geoffrich @AuroDesignSystem