Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-checkbox: error should be boolean, not string #33

Closed
geoffrich opened this issue Aug 16, 2021 · 1 comment · Fixed by #34
Closed

auro-checkbox: error should be boolean, not string #33

geoffrich opened this issue Aug 16, 2021 · 1 comment · Fixed by #34
Assignees
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@geoffrich
Copy link
Contributor

Describe the bug

The error prop on individual checkboxes is documented as a boolean, but in the code it's a string.

error: {
type: String,
reflect: true
},

This issue manifests identically to AlaskaAirlines/auro-radio#50

Expected behavior

The auro-checkbox error prop is a boolean.

@geoffrich geoffrich added the Type: Bug Bug or Bug fixes label Aug 16, 2021
@geoffrich geoffrich added the Status: Work In Progress Issue or Pull Request work is in Progress label Aug 16, 2021
AuroDesignSystem pushed a commit that referenced this issue Aug 17, 2021
## [1.1.5](v1.1.4...v1.1.5) (2021-08-17)

### Bug Fixes

* update child state when group state changes [#31](#31) ([51970b0](51970b0))
* **auro-checkbox:** make error a boolean [#33](#33) ([6e06844](6e06844))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants