Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled doesn't work when used with a required group #58

Closed
jordanchang opened this issue Jun 7, 2022 · 0 comments · Fixed by #63
Closed

Disabled doesn't work when used with a required group #58

jordanchang opened this issue Jun 7, 2022 · 0 comments · Fixed by #63
Assignees
@blackfalcon
Labels
auro-checkbox Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@jordanchang
Copy link

Describe the bug

The disabled checkbox doesn't render in a disabled state when placed inside an auro-checkbox-group with a required attribute.

To Reproduce

Steps to reproduce the behavior:

  1. Create an checkbox-group with required set <auro-checkbox-group required/>
  2. Add a disabled auro-checkbox: <auro-checkbox name="mygroup" disabled={true} value="option 1" >
  3. Disabled checkbox is still enabled.

Expected behavior

Should be disabled

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version: latest

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.
@jordanchang jordanchang added the Type: Bug Bug or Bug fixes label Jun 7, 2022
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress auro-checkbox labels Jun 8, 2022
@blackfalcon blackfalcon changed the title auro-checkbox: Disabled doesn't work when used with a required auro-checkbox-group Disabled doesn't work when used with a required group Jun 10, 2022
blackfalcon added a commit that referenced this issue Jun 10, 2022
@blackfalcon
fix(disabled state): address bug when used with required group #58
7795245 
Changes to be committed:
modified:   demo/index.html
modified:   src/auro-checkbox-group.js
@blackfalcon blackfalcon mentioned this issue Jun 10, 2022
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Jun 10, 2022 that will close this issue
Address bug when used with required group #63
Merged
6 tasks
blackfalcon added a commit that referenced this issue Jun 10, 2022
@blackfalcon
fix(disabled state): address bug when used with required group #58
e50f12a 
Changes to be committed:
modified:   demo/index.html
modified:   src/auro-checkbox-group.js
AuroDesignSystem pushed a commit that referenced this issue Jun 10, 2022
@semantic-release-bot
chore(release): 1.1.11 [skip ci]
93630a9 
## [1.1.11](v1.1.10...v1.1.11) (2022-06-10)

### Bug Fixes

* **disabled state:** address bug when used with required group [#58](#58) ([e50f12a](e50f12a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-checkbox Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address bug when used with required group AlaskaAirlines/auro-checkbox
2 participants
@blackfalcon @jordanchang