Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature to use new validity pattern #68

Closed
blackfalcon opened this issue Oct 13, 2022 · 1 comment · Fixed by #74
Closed

Update feature to use new validity pattern #68

blackfalcon opened this issue Oct 13, 2022 · 1 comment · Fixed by #74
Assignees
@jason-capsule42
Labels
auro-checkbox Type: Feature New Feature
Milestone
error state

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

The auro-checkbox element requires an update to meet new validation and error experiences.

Describe the solution you'd like

Update auro-select to use the new validity pattern as set by auro-input, combobox, etc...

Exit criteria

This issue will be considered complete once the user and code experience matches the newly set validity pattern and the element API behaves in the same way.
@jason-capsule42 jason-capsule42 self-assigned this Nov 7, 2022
jason-capsule42 added a commit that referenced this issue Nov 16, 2022
@jason-capsule42
feat(validity): add new html5 validity to component #68
dd4cc36
@jason-capsule42 jason-capsule42 mentioned this issue Nov 16, 2022
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Nov 16, 2022 that will close this issue
feat(validity): add new html5 validity to component #68 #74
Merged
6 tasks
@leeejune
Copy link
Contributor

leeejune commented Nov 23, 2022 •
edited
Loading

Error state design changes

Form label (heading): stay as auro-color-text-primary-on-light instead of changing to auro-color-text-error-on-light

Helper text: size should be SMALL body text size, color remain as red

Label (text next to button): stay as auro-color-text-primary-on-light instead of changing to auro-color-text-error-on-light

Spacing between last form element and helper text: auro-size-200

Screen Shot 2022-11-22 at 4 28 23 PM

@jason-capsule42

jason-capsule42 added a commit that referenced this issue Nov 29, 2022
@jason-capsule42
feat(validity): add new html5 validity to component #68
a1cfa39
AuroDesignSystem pushed a commit that referenced this issue Nov 29, 2022
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
d2a73a8 
# [1.2.0](v1.1.11...v1.2.0) (2022-11-29)

### Features

* **validity:** add new html5 validity to component [#68](#68) ([a1cfa39](a1cfa39))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
auro-checkbox Type: Feature New Feature
Projects
None yet
Milestone
error state
Development

Successfully merging a pull request may close this issue.

feat(validity): add new html5 validity to component #68 AlaskaAirlines/auro-checkbox
3 participants
@blackfalcon @jason-capsule42 @leeejune