Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSS token per new design system theming capability #154

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Update CSS token per new design system theming capability #154

merged 6 commits into from
Dec 5, 2023

Conversation

fajar-apri-alaska
Copy link
Contributor

Alaska Airlines Pull Request

Fixes: #153

Summary:

  • Update the design tokens to reflect the new theming conventions regarding tokens from the AuroDesignTokens and JetstreamDesignTokens repo.

Type of change:

Please delete options that are not relevant.

  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@fajar-apri-alaska fajar-apri-alaska requested a review from a team as a code owner October 27, 2023 07:29
@fajar-apri-alaska
perf(token): update token per new theming #153
b4a8f20 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   README.md
	modified:   demo/index.html
	modified:   package.json
	modified:   src/style.scss
@fajar-apri-alaska
Copy link
Contributor Author

The npm ci is failing because some auro components have conflicting peer dependency for @aurodesignsystem/webcorestylesheets package. Should I hold of this until those components are updated?

@fajar-apri-alaska fajar-apri-alaska linked an issue Oct 31, 2023 that may be closed by this pull request
auro-combobox: Theming support #153
Closed
@fajar-apri-alaska
chore(deps): update auro component dependencies
da56999 
- bump auro-dropdown

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
blackfalcon
blackfalcon requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to update all package dependencies and update repo to support our Node support policy https://auro.alaskaair.com/node-support#gsc.tab=0

demo/index.html Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
@fajar-apri-alaska
Copy link
Contributor Author

fajar-apri-alaska commented Nov 10, 2023 •
edited
Loading

Please be sure to update all package dependencies and update repo to support our Node support policy https://auro.alaskaair.com/node-support#gsc.tab=0

Does this means that we will need to work on changes based on node 18 updates for this component also? Sure, I could do that in a new issue ticket.

Edit:
Oh this component have already updated to node 18, my bad. All I need to do is to update the node engines to below value right?

"engines": {
  "node": "^18 || ^20"
}

@fajar-apri-alaska
chore(deps): update package dependency
f2262b9 
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
@fajar-apri-alaska
chore(deps): full dependency updates
aee7a23 
- update node engine to 18|20
- keep @web/test-runner at 0.16.1 since 0.18.0 make the test fails

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
jason-capsule42
jason-capsule42 requested changes Nov 16, 2023
View reviewed changes
package.json Show resolved Hide resolved
@fajar-apri-alaska
ci: update testPublish.yml
30ca974 
- include node version 20 to the jobs
blackfalcon
blackfalcon requested changes Nov 29, 2023
View reviewed changes
package.json Show resolved Hide resolved
@fajar-apri-alaska
ci: update git settings.yml
0adbad9 
- update status checks context value to include node 20 and cla license

Changes to be committed:
	modified:   .github/settings.yml
@jason-capsule42 jason-capsule42 merged commit 9f381fa into main Dec 5, 2023
4 checks passed
@jason-capsule42 jason-capsule42 deleted the fajarapri/updateCSSToken branch December 5, 2023 00:50
@blackfalcon
Copy link
Member

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-capsule42 jason-capsule42 jason-capsule42 approved these changes

@blackfalcon blackfalcon Awaiting requested review from blackfalcon

Assignees
No one assigned
Labels
released Completed work has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auro-combobox: Theming support
3 participants
@fajar-apri-alaska @blackfalcon @jason-capsule42