Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate auro-calendar code into auro-datepicker #105

Closed
Tracked by #106
jordanjones243 opened this issue Feb 22, 2023 · 1 comment
Closed
Tracked by #106

Incorporate auro-calendar code into auro-datepicker #105

jordanjones243 opened this issue Feb 22, 2023 · 1 comment
Assignees
@jordanjones243
Labels
auro-datepicker
Milestone
Date range select...

Comments

@jordanjones243
Copy link
Contributor

General Support Request

Support request

Since auro-calendar is a component that is only used within another component (datepicker), we want to move the auro-calendar code into auro-datepicker so that calendar does not have it's own standalone repo, making it easier to maintain.

Possible Solution

Move the auro-calendar code into auro-datepicker.
@jordanjones243 jordanjones243 added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members labels Feb 22, 2023
@jordanjones243 jordanjones243 self-assigned this Feb 22, 2023
jordanjones243 added a commit that referenced this issue Mar 2, 2023
@jordanjones243
refactor(calendar): add auro-calendar code within repo #105
e726478 
This commit will move all of the code from auro-calendar into the auro-datepicker repo, making it so that auro-calendar is no longer it's own standalone component.

Changes to be committed:
new file:   src/auro-calendar-month.js
new file:   src/auro-calendar.js
new file:   src/style-auro-calendar-month.scss
new file:   src/style-auro-calendar.scss
@jordanjones243 jordanjones243 mentioned this issue Mar 2, 2023
Closed
6 tasks
@jordanjones243 jordanjones243 linked a pull request Mar 2, 2023 that will close this issue
Create wc-date-range poc #108
Closed
6 tasks
@blackfalcon blackfalcon added Type: performance auro-datepicker and removed auro-datepicker not-reviewed Issue has not been reviewed by Auro team members labels Mar 7, 2023
@jason-capsule42 jason-capsule42 mentioned this issue Mar 20, 2023
Closed
40 tasks
@jason-capsule42
Copy link
Member

Closing this ticket - work moved into the development work for #106

jason-capsule42 pushed a commit that referenced this issue Apr 25, 2023
@jordanjones243 @jason-capsule42
refactor(calendar): add auro-calendar code within repo #105
6cebaf3 
This commit will move all of the code from auro-calendar into the auro-datepicker repo, making it so that auro-calendar is no longer it's own standalone component.

Changes to be committed:
new file:   src/auro-calendar-month.js
new file:   src/auro-calendar.js
new file:   src/style-auro-calendar-month.scss
new file:   src/style-auro-calendar.scss

BREAKING CHANGE: incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html

feat(calendar): BREAKING CHANGE incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html
jason-capsule42 pushed a commit that referenced this issue Apr 25, 2023
@jordanjones243 @jason-capsule42
refactor(calendar): BREAKING CHANGE add auro-calendar code within repo …
87cc297 
…#105

This commit will move all of the code from auro-calendar into the auro-datepicker repo, making it so that auro-calendar is no longer it's own standalone component.

Changes to be committed:
new file:   src/auro-calendar-month.js
new file:   src/auro-calendar.js
new file:   src/style-auro-calendar-month.scss
new file:   src/style-auro-calendar.scss

BREAKING CHANGE: incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html

feat(calendar): BREAKING CHANGE incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html
jason-capsule42 pushed a commit that referenced this issue May 16, 2023
@jordanjones243 @jason-capsule42
refactor(calendar): BREAKING CHANGE add auro-calendar code within repo …
c0f91a6 
…#105

This commit will move all of the code from auro-calendar into the auro-datepicker repo, making it so that auro-calendar is no longer it's own standalone component.

Changes to be committed:
new file:   src/auro-calendar-month.js
new file:   src/auro-calendar.js
new file:   src/style-auro-calendar-month.scss
new file:   src/style-auro-calendar.scss

BREAKING CHANGE: incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html

feat(calendar): BREAKING CHANGE incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html
blackfalcon pushed a commit that referenced this issue May 16, 2023
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
c0658f2 
# [2.0.0](v1.2.9...v2.0.0) (2023-05-16)

### Bug Fixes

* add and implement functional arrows on calendar ([3101703](3101703))
* **bundler:** define elements directly so bundler will work ([b622918](b622918))
* **calendar:** add number of calendar functionality ([330328a](330328a))
* **calendar:** correct number of calendars show for min/max dates ([1f81872](1f81872))
* **calendar:** import packages needed by wc-range-datepicker ([8a6bbe7](8a6bbe7))
* **calendar:** render correct calendar month and year ([cee087c](cee087c))
* **cell:** cell element now works correctly ([2a61b1b](2a61b1b))
* **dateTo:** prevent dateTo getting set to null causing old date to show in input ([de862e4](de862e4))
* **error:** setting or removing error attribute after firstUpdate works correcly. ([1c7ba1c](1c7ba1c))
* **examples:** correct code that broke two examples ([920bef3](920bef3))
* **help:** doesnt show help text when value is undefined ([ce87503](ce87503))
* **layout:** correct flex direction for mobile ([8f4850a](8f4850a))
* **layout:** in mobile last calender no longer partially behind gradient ([e39a466](e39a466))
* manage month visibility when dealing with min date ([4697703](4697703))
* **mobile:** back button is always blue now ([9305ded](9305ded))
* **mobile:** fix date selected text on mobile ([8bf37ce](8bf37ce))
* **numCalendars:** force render when numCalendars change ([84580a9](84580a9))
* **numCalenders:** fix min and max dates causes too many calendars to display ([22aeea9](22aeea9))
* **render:** render correct calendars based on window width ([d148730](d148730))
* **support:** support default and range scenarios ([2431cbb](2431cbb))
* **text:** revert date string text sequence ([116e651](116e651))
* **UI:** correct divider in dates on mobile bib header ([cfd6442](cfd6442))
* **validate:** cleanup validate method and event ([f0a63ba](f0a63ba))
* **validate:** not run validate on dropdown hide if bib was not visibile ([d1ac01f](d1ac01f))
* **validation:** correctly triggers validation ([09038d9](09038d9))
* **validation:** use the correct new validation API for input ([eda8daa](eda8daa))
* **value:** reset return value when date range is invalid ([3b3c04b](3b3c04b))
* **value:** setting value will move calendar month viewed ([eac8969](eac8969))

### Code Refactoring

* **calendar:** BREAKING CHANGE add auro-calendar code within repo [#105](#105) ([c0f91a6](c0f91a6))

### Features

* **API:** correct value setting behavior ([512c936](512c936))
* **api:** expose monthNames attribute for localization ([a6e3d24](a6e3d24))
* **api:** refactor functional value setting code, validation and some styles ([f4eeb2f](f4eeb2f))
* **event:** fire event when value or valueend changes ([31b97cf](31b97cf))
* **helpText:** support custom message for rangeUnderflow and Overflow ([022116f](022116f))
* **mobile:** add mobile layout and styles [#107](#107) ([c0ccd32](c0ccd32))
* **styles:** make new calendar match figma ([681b746](681b746))
* **validate:** fire event when validation occurs ([1f3e6fa](1f3e6fa))
* **validate:** make validate method private ([99db634](99db634))

### Performance Improvements

* **API:** cleanup JS code ([874518d](874518d))
* **cdn:** change all cdn references to jsdeliver ([cf2f6d5](cf2f6d5))
* **deps:** move auro deps to direct deps ([f62ccb6](f62ccb6))
* **deps:** update dependency versions ([736db5c](736db5c))
* **deps:** update to latest auro dependency versions ([928eedb](928eedb))
* **deps:** update to latest auro-input release with validity change ([d9dcf5e](d9dcf5e))
* **deps:** update to latest dependencies ([c0b9f51](c0b9f51))
* **deps:** update to latest dependency releases ([f5f5bd1](f5f5bd1))
* **deps:** update to lit 2 ([1c65c1a](1c65c1a))
* **deps:** use latest auro-input release with public validate method ([7eed8e2](7eed8e2))
* **nav:** improve navigation through calendar months with min and max dates defined ([2861fff](2861fff))
* **styles:** additional style cleanup ([2672f2e](2672f2e))
* **styles:** use variable for single fixed pixel dimension per review ([ed002b4](ed002b4))
* **syntax:** clean up linting errors ([481390c](481390c))
* **validate:** move validate call to focusout ([ae11cfc](ae11cfc))
* **validation:** rework entire validation process ([a7a0617](a7a0617))

### BREAKING CHANGES

* **calendar:** incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html

feat(calendar): BREAKING CHANGE incorporate new wc-date-range

This commit will blow away the use of Lion calendar and use a new calendar called wc-date-range, allowing for a date range to be selected within an auro-calendar.

Changes to be committed:
modified:   apiExamples/maxDate.html
modified:   apiExamples/maxDate.js
modified:   apiExamples/minDate.html
modified:   apiExamples/minDate.js
modified:   apiExamples/value.js
modified:   demo/api.html
modified:   demo/api.js
modified:   demo/api.md
modified:   demo/index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-datepicker
Projects
None yet
Milestone
Date range selection feature
Development

Successfully merging a pull request may close this issue.

Create wc-date-range poc AlaskaAirlines/auro-datepicker
3 participants
@blackfalcon @jason-capsule42 @jordanjones243