Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"auroDatePicker-valueSet" event not firing on date selection #188

Closed
arrenleung opened this issue Jan 17, 2024 · 1 comment · Fixed by #190
Closed

"auroDatePicker-valueSet" event not firing on date selection #188

arrenleung opened this issue Jan 17, 2024 · 1 comment · Fixed by #190
Assignees
@jason-capsule42
Labels
auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@arrenleung
Copy link
Contributor

Please verify the version of auro-datepicker you have installed

2.1.2

Please describe the bug

  1. Instantiate a datepicker component with an event listener for auroDatePicker-valueSet
  2. Select a date in the calendar
  3. See that nothing happens in your valueSet event listener method

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

The auroDatePicker-valueSet event is fired from the datepicker when a date is selected

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Additional context

No response

Exit criteria

The auroDatePicker-valueSet event is fired from the datepicker when a date is selected
@arrenleung arrenleung added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jan 17, 2024
@arrenleung
Copy link
Contributor Author

arrenleung commented Jan 17, 2024 •
edited
Loading

The problem is caused by the latest version of auro-input that updated cleave.js to v1.6.0:
image
Downgrading to auro-input@2.15.1 and installing cleave.js@1.5.10 locally seems to fix the issue.

jason-capsule42 added a commit that referenced this issue Jan 23, 2024
@jason-capsule42
fix(event): always fire notify event when value changes #188
f3a4b40
@jason-capsule42 jason-capsule42 mentioned this issue Jan 23, 2024
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jan 23, 2024 that will close this issue
fix(event): always fire notify event when value changes #188 #190
Merged
6 tasks
jordanjones243 pushed a commit that referenced this issue Jan 23, 2024
@jason-capsule42 @jordanjones243
fix(event): always fire notify event when value changes #188
9108e46
blackfalcon pushed a commit that referenced this issue Jan 23, 2024
@semantic-release-bot
chore(release): 2.2.1 [skip ci]
a3c0163 
## [2.2.1](v2.2.0...v2.2.1) (2024-01-23)

### Bug Fixes

* **event:** always fire notify event when value changes [#188](#188) ([9108e46](9108e46))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(event): always fire notify event when value changes #188 AlaskaAirlines/auro-datepicker
5 participants
@blackfalcon @jason-capsule42 @arrenleung @Patrick-Daly-AA @pgm369