Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The auro-calendar is not adjusting it's height for the mobile address bar #222

Closed
jason-capsule42 opened this issue Apr 26, 2024 · 0 comments · Fixed by #223
Closed

The auro-calendar is not adjusting it's height for the mobile address bar #222

jason-capsule42 opened this issue Apr 26, 2024 · 0 comments · Fixed by #223
Assignees
@jason-capsule42 @Patrick-Daly-AA
Labels
auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@jason-capsule42
Copy link
Member

Please verify the version of auro-datepicker you have installed

2.5

Please describe the bug

  1. Go the any datepicker on a mobile device
  2. Tap to ensure the full address bar is displayed
  3. Open the dapicker calendar
  4. See that the "done" button is cropped behind the address bar

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

The height should adjust to account for the mobile address bar

What browsers are you seeing the problem on?

Chrome, Safari

Additional context

No response

Exit criteria

The calendar must be updated to account for the mobile address bar. This can be done by using height: 100dvh. which is Device Visual Height.
@jason-capsule42 jason-capsule42 added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Apr 26, 2024
@jason-capsule42 jason-capsule42 self-assigned this Apr 26, 2024
jason-capsule42 added a commit that referenced this issue Apr 26, 2024
@jason-capsule42
fix(mobile): correct height calculation to account for dynamic displa…
21d79a3 
…y of mobile address bar #222
@jason-capsule42 jason-capsule42 mentioned this issue Apr 26, 2024
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Apr 26, 2024 that will close this issue
Update height calculation for mobile address bar #223
Merged
6 tasks
jason-capsule42 added a commit that referenced this issue Apr 26, 2024
@jason-capsule42
fix(mobile): correct height calculation to account for dynamic displa…
483de44 
…y of mobile address bar #222
blackfalcon pushed a commit that referenced this issue Apr 26, 2024
@semantic-release-bot
chore(release): 2.5.1 [skip ci]
b2b00e7 
## [2.5.1](v2.5.0...v2.5.1) (2024-04-26)

### Bug Fixes

* **mobile:** correct height calculation to account for dynamic display of mobile address bar [#222](#222) ([483de44](483de44))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

@Patrick-Daly-AA Patrick-Daly-AA

Labels
auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update height calculation for mobile address bar AlaskaAirlines/auro-datepicker
2 participants
@jason-capsule42 @Patrick-Daly-AA