Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-counter group needs dropdown enhancement #250

Closed
sun-mota opened this issue Jan 22, 2025 · 1 comment · Fixed by #284
Closed

auro-counter group needs dropdown enhancement #250

sun-mota opened this issue Jan 22, 2025 · 1 comment · Fixed by #284
Assignees
@rmenner
Labels
auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@sun-mota
Copy link
Contributor

sun-mota commented Jan 22, 2025 •
edited by rmenner
Loading

Is your feature request related to a problem? Please describe.

we need a way to customize the label on Auro-counter-group when it has isDropdown attribute.

Example of the use of the customized label
Image

---- edit ----

Acceptance criteria

  • Enable dropdown label slot (formally placeholder slot)
  • Create text-value slot (can override default content)
  • Populate text-value with default content (1 Adult, 2 Children, 0 Infant)
  • Enable dropdown helptext slot
@sun-mota sun-mota added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Jan 22, 2025
@sun-mota
Copy link
Contributor Author

Related to #15

@rmenner rmenner self-assigned this Jan 28, 2025
rmenner added a commit that referenced this issue Jan 29, 2025
@rmenner
feat: enhance dropdown rendering with value, label, and help text slots
ef3b7de 
#250
@rmenner rmenner linked a pull request Jan 29, 2025 that will close this issue
Counter dropdown content enhancement #284
Merged
@rmenner rmenner changed the title auro-counter-group - custom label auro-counter auro-counter-group needs custom label, value text, and help text Jan 29, 2025
@rmenner rmenner changed the title auro-counter auro-counter-group needs custom label, value text, and help text auro-counter auro-counter-group needs dropdown enhancement Jan 29, 2025
@rmenner rmenner changed the title auro-counter auro-counter-group needs dropdown enhancement auro-counter group needs dropdown enhancement Jan 29, 2025
rmenner added a commit that referenced this issue Jan 29, 2025
@rmenner
test: add unit tests for handling various counter group scenarios in …
576626e 
…dropdown #250
rmenner added a commit that referenced this issue Jan 29, 2025
@rmenner
chore: remove test comment and add slot api descriptions #250
ab5a9e7
rmenner added a commit that referenced this issue Jan 29, 2025
@rmenner
feat: enhance dropdown rendering with value, label, and help text slots
ab7d1b3 
#250
rmenner added a commit that referenced this issue Jan 29, 2025
@rmenner
test: add unit tests for handling various counter group scenarios in …
4b2c552 
…dropdown #250
rmenner added a commit that referenced this issue Jan 29, 2025
@rmenner
chore: remove test comment and add slot api descriptions #250
874f1a3
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
feat: enhance dropdown rendering with value, label, and help text slots
780e7b7 
#250
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
test: add unit tests for handling various counter group scenarios in …
45251b5 
…dropdown #250
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
chore: remove test comment and add slot api descriptions #250
1b74863
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
feat: enhance dropdown rendering with value, label, and help text slots
18822b1 
#250
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
test: add unit tests for handling various counter group scenarios in …
d4af48f 
…dropdown #250
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
chore: remove test comment and add slot api descriptions #250
2cc96c1
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
feat: enhance dropdown rendering with value, label, and help text slots
7a14d3e 
#250
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
test: add unit tests for handling various counter group scenarios in …
0d80978 
…dropdown #250
rmenner added a commit that referenced this issue Jan 30, 2025
@rmenner
chore: remove test comment and add slot api descriptions #250
b58cca3
jason-capsule42 pushed a commit that referenced this issue Jan 30, 2025
@semantic-release-bot
chore(release): 2.0.0-beta.30 [skip ci]
ba18e30 
# [2.0.0-beta.30](v2.0.0-beta.29...v2.0.0-beta.30) (2025-01-30)

### Bug Fixes

* check deep nested slots with recusive function ([6ab4435](6ab4435))

### Features

* enhance dropdown rendering with value, label, and help text slots [#250](#250) ([7a14d3e](7a14d3e))
@rmenner rmenner closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmenner rmenner

Labels
auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Counter dropdown content enhancement AlaskaAirlines/auro-formkit
3 participants
@rmenner @sun-mota @Patrick-Daly-AA