Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-datepicker is slightly(2px) bigger than other components #271

Closed
sun-mota opened this issue Jan 24, 2025 · 2 comments · Fixed by #276 or #293
Closed

auro-datepicker is slightly(2px) bigger than other components #271

sun-mota opened this issue Jan 24, 2025 · 2 comments · Fixed by #276 or #293
Assignees
Labels
auro-form not-reviewed Issue has not been reviewed by Auro team members released on @beta Type: Bug Bug or Bug fixes

Comments

@sun-mota
Copy link
Contributor

sun-mota commented Jan 24, 2025

Please verify the version of auro-form you have installed

No response

Please describe the bug

While combobox and input are 58px height, datepicker is 60px height

Image

Image

Reproducing the error

None

Expected behavior

all should be the 56px tall according to the blueprint
https://www.figma.com/design/ClsrU5j9yHiLA35bq7IRuO/Input?node-id=896-12109&m=dev

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response

@sun-mota sun-mota added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jan 24, 2025
@sun-mota sun-mota assigned sun-mota and unassigned Patrick-Daly-AA Jan 24, 2025
sun-mota added a commit that referenced this issue Jan 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
sun-mota added a commit that referenced this issue Jan 24, 2025
jason-capsule42 pushed a commit that referenced this issue Jan 24, 2025
# [2.0.0-beta.24](v2.0.0-beta.23...v2.0.0-beta.24) (2025-01-24)

### Bug Fixes

* make datepicker's height the same as other components' height [#271](#271) ([40f206d](40f206d))
@sun-mota sun-mota reopened this Jan 30, 2025
@sun-mota
Copy link
Contributor Author

still reproducing

sun-mota added a commit that referenced this issue Jan 31, 2025
jason-capsule42 pushed a commit that referenced this issue Jan 31, 2025
# [2.0.0-beta.31](v2.0.0-beta.30...v2.0.0-beta.31) (2025-01-31)

### Bug Fixes

* add margin only when the slotted node has contents [#271](#271) ([7ef1ef8](7ef1ef8))
@jason-capsule42
Copy link
Member

🎉 This issue has been resolved in version 2.0.0-beta.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-form not-reviewed Issue has not been reviewed by Auro team members released on @beta Type: Bug Bug or Bug fixes
Projects
None yet
3 participants